-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling local config saving (one source of truth) #485
Comments
This comment was marked as outdated.
This comment was marked as outdated.
why this issue is closed? can we reopen it? |
Yeah, feel free to submit a PR |
Hiya @hppyworld @krswin and @epheterson |
This is great, thanks! Just updated it and happy to see the "Save Locally" button disabled. Ironically, it did take a few saves and resetting local settings to stick, but now all good! Also noticed a little typo on the settings:
You either need "no users" or "will not" but currently it's a double-negative. |
It's looking like if I don't "Reset Local Settings" then I can never locally apply updates from the config file. Is that by design? Example –
|
So that's not actually local storage, just the backend taking a minute to recompile the frontend. You can check the dev tools, specifically local storage (not saved), network request (xhr to save to disk) and console (status is logged there) |
Thanks for explaining, though is there anything that can be done to speed it up? Dashy is great except for the editing flow which leaves you waiting to see your changes, sometimes leaving you wondering if they saved at all. |
It's VueCLU which is slow. These architectural changes would need to be made:
|
The edit workflow is really a bit scary if not saved correctly automatically as usual. Dashy shows the message: "Saved to Disk" after saving. At this point there should be a hint what happens now or that you have to wait or something. When I press F5 everything is gone... Uploading a backup every time can't be the right way. Do I understand correctly that you should wait 1 minute after pressing "Save to Disk"? |
Hate to say it but I switched to Homarr and this is the primary reason. Saving should be simple and immediately verifiable. |
I give it another go because what Lissy93 has created here is really really great :) except of editing ;) |
I have been working on a totally new unified config loading method past few days. Should be ready in a week or two. The reason it's so confusing atm, is because I never expected people would want to edit their config through the UI, but it kept being requested, so I added it but the initial config loading method wasn't really designed for it, which is why I'm rebuilding that at the moment :) |
Agree Dashy is great, looking forward to trying it again when the new method comes out! Thanks for all your hard work on it @Lissy93! |
It's surprisingly difficult and frustrating trying to set this up in the UI and preserving all changes. Each change requires being saved first locally, then separately going back in and saving remotely. Then you must clear the cache to confirm it's saved, which often for some reason it isn't.
For users who don't care for a separate local/permanent config, this dance is very unnecessary. Please allow having a single source of truth, which would simplify updating the config file.
The text was updated successfully, but these errors were encountered: