Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature support emoji icons #76

Merged
merged 7 commits into from
Jul 3, 2021
Merged

Feature support emoji icons #76

merged 7 commits into from
Jul 3, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Jul 3, 2021

Category: Feature

Overview
Adds support for using emojis as item icons. Some users do not like loading font-awesome, and since emojis are supported natively by most browsers, it seemed like something I should implement. Of course, font-awesome, favicon, generative, and direct-url item icon formats are all still supported.

Emojis can either be specified directly, or using shortcode, or using Unicode. E.g:

items:
  - title: Emoji
    icon: 🚀
  - title: Shortcode
    icon: ':rocket:'
  - title: Unicode
    icon: 'U+1F680'

Issue Number N/A

New Vars N/A

Screenshot (if applicable)
image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance

@netlify
Copy link

netlify bot commented Jul 3, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: c27c8d6

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/60e0b1bea590130007afb5f5

😎 Browse the preview: https://deploy-preview-76--dashy-dev.netlify.app

@Lissy93 Lissy93 merged commit 702b69d into master Jul 3, 2021
@Lissy93 Lissy93 deleted the FEATURE_support-emoji-icons branch July 3, 2021 18:56
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant