Add support for persistent superchats #79
Conversation
…sticky-superchats
There was a problem hiding this comment.
Some extra stuff aside from the comments:
-
The ticker bar seems to just disappear randomly and never come back? I experienced this during Watame's BDay live on both Firefox and Chromium. Seems to only affect live streams and not VODs. No errors in the console.
-
If we want to use name for the ticker items instead of profile pic like YTC does, we might want to truncate it in case of people with long names taking up too much space like this one:
-
Membership items (not talking about gifts) and membership milestone chats aren't being stickied even though they are on normal YTC.
-
Adding a setting to toggle the ticker bar would be nice.
src/components/Settings.svelte
Outdated
| :global(::-webkit-scrollbar) { | ||
| width: 4px; | ||
| height: 4px; | ||
| } | ||
| :global(::-webkit-scrollbar-track) { | ||
| * :global(::-webkit-scrollbar-track) { | ||
| background: transparent; | ||
| } | ||
| :global(::-webkit-scrollbar-thumb) { | ||
| background: #888; | ||
| } | ||
| :global(::-webkit-scrollbar-thumb:hover) { | ||
| background: #555; | ||
| * { | ||
| scrollbar-width: thin; | ||
| scrollbar-color: #888 transparent; |
There was a problem hiding this comment.
webkit-scrollbar-track probably isn't needed if thin scrollbars are removed. Also if we're removing thin scrollbars here on Chrome, we should also remove it on Firefox.
| <div slot="actions"> | ||
| <Button on:click={() => { | ||
| $focusedSuperchat = null; | ||
| }} color="primary">Close</Button> | ||
| </div> |
There was a problem hiding this comment.
The close button feels unnecessary.
|
Ran with Astel's BDay live and now the ticker bar is always there but new superchats aren't added to it lmao |
this is intentional, imo they dont belong in the superchat bar and it just gets in the way of actual messages that need to be stickied so imma leave that as it is |
|
altho ig there are membership joins with messages, we could add that later possibly |
src/components/Hyperchat.svelte
Outdated
| <div class="absolute top-0 w-full"> | ||
| {#if $enableStickySuperchatBar} | ||
| <StickyBar /> | ||
| {/if} | ||
| {#if pinned} | ||
| <div class="mx-2 mt-2"> | ||
| <PinnedMessage pinned={pinned} /> | ||
| </div> | ||
| {/if} | ||
| </div> |
There was a problem hiding this comment.
Sticky bar blocks the top most message since its in an absolute div:
There was a problem hiding this comment.
this is the same with pinned messages btw.
2022-06-13.22-50-52.mp4 |
|
LMAO I assumed you were gonna just put the sticky bar as a separate div above the "main" HC div like how YTC does it:
Could you try to do that instead, or is there some other problem preventing that? Seems to me like it'll involve a lot less fucking around with the heights and stuff and will fix this OCD trigger: 2022-06-16.18-17-40.mp4 |
| chrome.windows.create({ | ||
| url: request.url, | ||
| type: 'popup', | ||
| height: 420, | ||
| width: 690 | ||
| type: 'popup' | ||
| }, () => {}); |
There was a problem hiding this comment.
We sure we wanna remove the width/height? The defaults seems a tad large.
|
I've fixed the OCD trigger in ba7bc8d, so the sticky bar is no longer in an absolute div. Pinned messages not blocking the top few messages is nice so we should still keep that part regardless. For the popup, I think we should still specify a certain size instead of letting the browser wing it and fill up half of the screen. Maybe slightly larger than before if needed. |
|
@ChrRubin chrome now inconsistently enforces a minimum pop-up window area size based on the percentage of area it occupies. I realized this while deving on my laptop -- chrome throws an error if a window takes less than 50% of available screen area, blocking the pop-up. Getting rid of the dimensions is the easiest solution, unless u wanna try messing with measuring screen dimensions and sht lol |
|
btw @ChrRubin here's the error, screenshotted from the production chrome listing
|
Jesus that's stupid. No wonder the default literally just fills up half of the screen on Chrome. |
There was a problem hiding this comment.
@KentoNishi you should double-check that my commit doesn't mess up any of the stuff you changed. Seems good to me at quick glance
|
Got it, will do after I get back to mah hotel |
Both files are reverted to pre #79
Implements #49