Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-186: Fix NuGet publish #73

Merged
merged 7 commits into from
Sep 10, 2022
Merged

OSOE-186: Fix NuGet publish #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b0c2b6b
Probably Invoke-BeforePack.ps1 is not needed anymore?
Piedone Sep 9, 2022
a110a63
Revert "Probably Invoke-BeforePack.ps1 is not needed anymore?"
Piedone Sep 9, 2022
327e1c6
Removing files from nuspec instead
Piedone Sep 9, 2022
a9ee821
Now Invoke-BeforePack.ps1 is not needed indeed
Piedone Sep 9, 2022
adc02bb
Updating package references to latest alpha
Piedone Sep 9, 2022
2b67bfa
Re-adding comment on why we're excluding files from NuGet
Piedone Sep 9, 2022
9e4dcef
Before publish.
sarahelsaig Sep 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions Invoke-BeforePack.ps1
View file
Open in desktop

This file was deleted.

10 changes: 9 additions & 1 deletion Lombiq.Analyzers/Lombiq.Analyzers.nuspec.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
<metadata>
<id>Lombiq.Analyzers</id>
Expand All @@ -17,4 +17,12 @@
<!-- Dependencies come here from CommonPackages.props. -->
</dependencies>
</metadata>
<files>
<!-- Workaround for NuGet's validation caused by the presence of these files:
- bin/Release/netstandard2.0/Lombiq.Analyzers.dll
- obj/Release/netstandard2.0/Lombiq.Analyzers.dll
The cause is probably that we don't actually do anything in this csproj, it only exists because we need an entry
point for `dotnet pack` (unlike the older `nuget pack` tooling, which worked with just the .nuspec alone).-->
<file src="**" exclude="**\bin\**;**\obj\Release\**" />
</files>
</package>
2 changes: 1 addition & 1 deletion ...ombiq.Analyzers.PackageReference/IndirectPackageReference/IndirectPackageReference.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
-->

<ItemGroup Condition="'$(ImportPackageAgain)' == 'true'">
<PackageReference Include="Lombiq.Analyzers" Version="2.1.1-osoe-110.22">
<PackageReference Include="Lombiq.Analyzers" Version="3.0.1">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
</ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Lombiq.Analyzers" Version="2.1.1-osoe-110.22">
<PackageReference Include="Lombiq.Analyzers" Version="3.0.1">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
</ItemGroup>
Expand Down