Skip to content

Commit

Permalink
Merge pull request #25 from Lombiq/issue/OSOE-155
Browse files Browse the repository at this point in the history
OSOE-155: Remove Edge installation from Linux builds
  • Loading branch information
sarahelsaig authored Jul 12, 2022
2 parents 7a99d35 + 0b0f117 commit 65ce615
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 41 deletions.
17 changes: 0 additions & 17 deletions .github/actions/setup-edge-linux/action.yml

This file was deleted.

11 changes: 0 additions & 11 deletions .github/actions/setup-edge-linux/setup-edge.ps1

This file was deleted.

12 changes: 0 additions & 12 deletions .github/workflows/build-and-test-orchard-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,6 @@ on:
type: number
default: 360
description: Configuration for the timeout-minutes parameter of the workflow. The 360 is GitHub's default.
setup-edge-on-linux:
required: false
type: boolean
default: false
description: Indicates whether to enable setup Edge on Linux.

jobs:
build-and-test:
Expand Down Expand Up @@ -117,13 +112,6 @@ jobs:
with:
location: ${{ inputs.build-directory}}

# Firefox and Chrome browsers are installed by default on ubuntu-latest and windows-latest, and Edge is installed by
# default on windows-latest, so here we install Edge on ubuntu-latest. It seems Linux support is planned here
# (https://github.com/browser-actions/setup-edge), after this completes we can use it.
- name: Set up Edge
uses: Lombiq/GitHub-Actions/.github/actions/setup-edge-linux@dev
if: ${{ inputs.setup-edge-on-linux }}

- name: Tests
uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@dev
with:
Expand Down
1 change: 0 additions & 1 deletion Docs/Actions.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ In addition to the below short explanations, check out the inline documentation
- `publish-nuget`: Publishes the content of the current directory as a NuGet package.
- `setup-azurite`: Sets up the [Azurite Azure Blob Storage Emulator](https://docs.microsoft.com/en-us/azure/storage/common/storage-use-azurite) via NPM.
- `setup-dotnet`: Sets up the .NET SDK.
- `setup-edge-linux`: Sets up the Microsoft Edge on Linux.
- `setup-sql-server`: Sets up SQL Server with Lombiq-recommended defaults.
- `test-dotnet`: Runs .NET unit and UI tests (with the [Lombiq UI Testing Toolbox for Orchard Core](https://github.com/Lombiq/UI-Testing-Toolbox)), generates a test report, and uploads UI testing failure dumps to artifacts.
- `verify-submodule-pull-request`: Assuming that the current repository is a submodule in another repository, this action verifies that a pull request with a matching issue code has been opened there as well.

0 comments on commit 65ce615

Please sign in to comment.