Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-464: Fixing that .NET build errors didn't fail the build #107

Merged
merged 3 commits into from
Nov 20, 2022
Merged

OSOE-464: Fixing that .NET build errors didn't fail the build #107

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6df3c1e
Failing build is dotnet build fails
Piedone Nov 20, 2022
1ef68b6
Not going overboard with exit codes
Piedone Nov 20, 2022
937fd22
Removing issue branch reference
Piedone Nov 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/actions/build-dotnet/Build-DotNetSolutionOrProject.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ dotnet build $SolutionOrProject @buildSwitches 2>&1 | ForEach-Object {
if ($noErrors) { Write-Output "::error file=$file,line=$line,col=$column::$message" }
}

if ($noErrors -and !$?)
{
exit 1
}

# With node reuse, dotnet build spawns processes that while speed up build, they can cause dotnet test and other dotnet
# tools to randomly hang. So, here we shut down those processes for later actions.
# For details see: https://github.com/Lombiq/UI-Testing-Toolbox/issues/228.
Expand Down