Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-470: Remove false entries (actual typos) from spell checking allow lists in Lombiq.GitHub.Actions #111

Merged
merged 61 commits into from
Dec 8, 2022
Merged
Show file tree
Hide file tree
Changes from 45 commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
16bc76f
Removing actual typos from allow.txt
porgabi Nov 21, 2022
c1ca94d
Working on removing typos from expect.txt
porgabi Nov 22, 2022
ef7ddcf
Removing typos from expect.txt
porgabi Nov 22, 2022
9ca2b2f
Removing typos from allow.txt
porgabi Nov 22, 2022
588fa07
Merge remote-tracking branch 'origin/dev' into issue/OSOE-470
porgabi Nov 23, 2022
27cd443
Cleaning up allow.txt
porgabi Nov 24, 2022
dc34eba
Merge remote-tracking branch 'origin/dev' into issue/OSOE-470
porgabi Nov 24, 2022
6ee63b8
Working on cleaning up expect.txt
porgabi Nov 24, 2022
79836fb
Removing most of the GUID pieces from expect.txt
porgabi Nov 24, 2022
48cc6ed
Removing item from expect.txt
porgabi Nov 24, 2022
788c7ae
Trying to break build
porgabi Nov 24, 2022
0212590
Trying to change config
porgabi Nov 24, 2022
2a72d46
Revert "Removing most of the GUID pieces from expect.txt"
porgabi Nov 24, 2022
179d8ec
Restoring necessary items
porgabi Nov 24, 2022
6822581
Merge remote-tracking branch 'origin/dev' into issue/OSOE-470
porgabi Nov 25, 2022
edc249f
Adding GUID regex in patterns.txt
porgabi Nov 25, 2022
1a5fbd2
Adjusting regex
porgabi Nov 25, 2022
fc2b39b
Again
porgabi Nov 25, 2022
025c782
Adding second regex for dashless GUID strings of 32 length
porgabi Nov 25, 2022
6722f91
Adjusting regex
porgabi Nov 25, 2022
b4d0b8e
Moving regex to expect.txt
porgabi Nov 25, 2022
4f144f6
Moving regex back to patterns.txt
porgabi Nov 25, 2022
b4b01f4
Reverting
porgabi Nov 25, 2022
f2be221
Testing
porgabi Nov 25, 2022
b9a0a10
Adding regex for sha IDs
porgabi Nov 26, 2022
e8c2ead
Merge remote-tracking branch 'origin/dev' into issue/OSOE-470
porgabi Nov 26, 2022
af76e0e
Testing
porgabi Nov 26, 2022
fb324f6
Removing a bunch of ID pieces from expect.txt
porgabi Nov 26, 2022
c88af43
Testing
porgabi Nov 26, 2022
8c20ec9
Trying adding regex for git commit hashes
porgabi Nov 26, 2022
d5cf7d0
Removing rest of the removables
porgabi Nov 26, 2022
1ee20ea
Merge remote-tracking branch 'origin/dev' into issue/OSOE-470
porgabi Nov 28, 2022
e8bb7c4
Merge remote-tracking branch 'origin/dev' into issue/OSOE-470
porgabi Nov 29, 2022
58fa6e0
Removing spelling allow list entries
BenedekFarkas Nov 29, 2022
8602a0e
Removing spell check allow list entries that aren't used in Lombiq
BenedekFarkas Nov 29, 2022
5db7a04
Removing unknown and redundant entries from spell checking expect.txt
BenedekFarkas Nov 29, 2022
009106d
Updating allow.txt and patterns.txt not to allow mixed case typings o…
BenedekFarkas Nov 29, 2022
165877d
Spell checking: Removing entries from patterns.txt where mixed casing…
BenedekFarkas Nov 29, 2022
1fab779
Spell checking: Moving "cmdlet" from expect.txt to allow.txt to also …
BenedekFarkas Nov 29, 2022
cf87358
Testing the spell checking strictness with mixed casing
BenedekFarkas Nov 29, 2022
269e28f
Lombiq? Lombiq
BenedekFarkas Nov 30, 2022
08e7a19
Readding mixed-cased pattern for Lombiq to check if detection works a…
BenedekFarkas Nov 30, 2022
646b413
Removing testing text/config
BenedekFarkas Nov 30, 2022
f443631
Merge remote-tracking branch 'origin/dev' into issue/OSOE-470
BenedekFarkas Dec 5, 2022
7426c71
Spell checking: Adding "cmdlets" to allow.txt (even though "cmdlet" w…
BenedekFarkas Dec 5, 2022
0167da5
Adding CSS map files to excludes
BenedekFarkas Dec 5, 2022
5601858
Update .github/actions/spelling/patterns.txt
BenedekFarkas Dec 5, 2022
187afc7
Update .github/actions/spelling/patterns.txt
BenedekFarkas Dec 5, 2022
ebec5dc
Updating patterns.txt with reordering and comments
BenedekFarkas Dec 5, 2022
485d64a
Adding regex pattern to ignore hex color codes from spellchecking
BenedekFarkas Dec 5, 2022
33a2f3e
Update .github/actions/spelling/patterns.txt
BenedekFarkas Dec 5, 2022
0f7782b
Adding comment to patterns.txt
BenedekFarkas Dec 5, 2022
0b37a80
Merge remote-tracking branch 'origin/dev' into issue/OSOE-470
BenedekFarkas Dec 5, 2022
3f390cb
Breaking up URL patterns into separate lines for readability
BenedekFarkas Dec 8, 2022
b194a5d
Removing overly unrestrictive spell check pattern that ignores everyt…
BenedekFarkas Dec 8, 2022
0132d61
Simplifying URL patterns
Dec 8, 2022
bf87881
Removing word-like entries with mixed casing from spell checking patt…
BenedekFarkas Dec 8, 2022
b5ad089
Merge remote-tracking branch 'origin/dev' into issue/OSOE-470
BenedekFarkas Dec 8, 2022
dcc12f6
Adding "cloudsmith" to allow.txt
BenedekFarkas Dec 8, 2022
0061f11
Excluding minified CSS and JS files from spell checking (they are ign…
BenedekFarkas Dec 8, 2022
1278ba4
Updating spelling workflow steps to use the dev branch version
BenedekFarkas Dec 8, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 9 additions & 27 deletions .github/actions/spelling/allow.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
Cdp
Codeuctivity
Deactivatable
Driectory
Drvier
Handlingtests
Hidiging
ISetup
IShell
IShortcuts
Expand All @@ -30,10 +25,8 @@ Inbox
JArray
JProperty
JValue
Magizoologist
MTHML
NCrontab
Satou
Subresource
TCategory
TCd
Expand Down Expand Up @@ -61,11 +54,13 @@ TStartup
TState
TTable
TView
Testenant
Timestamped
Timezones
Uninstalling
asynchronicity
atata
cmdlet
cmdlets
codebase
colorpicker
configurator
Expand All @@ -78,7 +73,6 @@ flyout
formattable
hashable
hca
helppopulartopics
hostnames
inheritdoc
isignal
Expand All @@ -88,20 +82,22 @@ johndoe
jon
jsonparse
langword
lifecyle
linq
listheader
logtest
misconfigured
multiselect
mvc
paramref
prebuilt
readme
retriable
rnwood
rpartition
rpdgwx
sanitizers
scrollbars
scroller
sfc
shortcutting
sitesettings
smtpport
Expand All @@ -110,10 +106,8 @@ taghelper
taxonomyexpensetags
taxonomyincometags
teamcity
tes
testuser
timespan
tkzog
toolbars
trainingdemo
transpiled
Expand All @@ -128,16 +122,12 @@ versionable
viewmodel
websites
whitelisted
would've
ASPNETCORE
Activatable
Antiforgery
Autherization
Configurator
ConfigureMockAutherizationService
Demystifier
Deployer
Embedd
Enums
Firefox
Formattable
Expand All @@ -152,7 +142,6 @@ IApplication
IAsync
IAudit
IAuthorization
IBab
IBackground
ICaching
ICant
Expand Down Expand Up @@ -264,15 +253,13 @@ Interop
Interoperability
JObject
JToken
LOMBIQ
Lombiq
lombiq
Lucene
Meziantou
Namespaced
Newtonsoft
Portainer
Reappend
Rowling
Schoorstra
Serializer
Shouldly
Expand All @@ -291,7 +278,7 @@ TValue
Toolset
Trumbowyg
USERPROFILE
Uncomment
uncomment
BenedekFarkas marked this conversation as resolved.
Show resolved Hide resolved
airbnb
allowlist
apiclienttenant
Expand Down Expand Up @@ -319,7 +306,6 @@ darkmode
dataprotection
datalabels
datatable
deactivatable
deconstructed
destructuring
devblogs
Expand All @@ -328,7 +314,6 @@ dotnet
endzone
executesql
facebook
flakyness
frontend
geckodriver
gitattributes
Expand All @@ -351,8 +336,6 @@ multisubmit
plugin
plugins
refactoring
registrationhttpevent
registrationworkflow
rolename
ruleset
screenshots
Expand All @@ -365,7 +348,6 @@ subfolder
subfolders
submenu
superproject
tanspiled
taxonomyfield
versioning
visualstudio
Expand Down
67 changes: 3 additions & 64 deletions .github/actions/spelling/expect.txt
Original file line number Diff line number Diff line change
@@ -1,33 +1,27 @@
Accessbility
Argb
Chro
Cloudflare
Cms
CDNs
EACCES
EULA
Egyw
GDPR
Hsl
IShortcode
JIRA
jira
BenedekFarkas marked this conversation as resolved.
Show resolved Hide resolved
MVVM
NLog
NONINFRINGEMENT
NPM
NVARCHAR
RHEL
RSPEC
Reks
Rekt
SFCs
SUSE
XDG
abcdefghijklmnopqrstuvwxyz
ble
blog
btn
Bubl
buble
certs
chainable
Expand Down Expand Up @@ -63,10 +57,8 @@ json
jsoneditor
jsoneditoronline
labelledby
length'l
linebreak
linkedin
linq
linting
linux
localhost
Expand All @@ -80,17 +72,16 @@ msbuild
mscorlib
msedgedriver
mso
mvc
myapp
navbar
ndproj
nologo
npx
nuget
omnisharp
onspecial
onwarn
orchardcore
osoce
parallelizable
pickr
plusplus
Expand All @@ -103,7 +94,7 @@ preheader
publishsettings
pwsh
readdir
search'f
sdk
setlocal
shortcode
sln
Expand Down Expand Up @@ -131,96 +122,44 @@ xsessionrc
xxl
yaml
yml
Aig
Airi
BJRQ
BOHq
Bcc
Cmi
DBs
Dci
ETbp
Efq
Erau
FNGAQ
Fhd
GVm
Graphi
HEUZ
HKx
HQXp
HRSF
Hvga
Hxn
JMES
Jmgx
KQl
KUhd
KWJv
MPRr
Moq
NHx
NTFS
Nbyf
Nepw
Nhd
Noda
PII
PWn
Panem
Postgre
QXSh
Qhd
Qvga
Qwxga
Regexes
Rkao
Rrg
SDl
SEH
SHx
SLc
Sckc
Smo
Svga
Sxga
Tful
Tgu
Tzdb
UPPf
UYdg
Uevh
Uocgz
Uwqhd
Vga
Vzl
Wjf
Wqhd
Wsxga
Wuxga
Wxga
Wysiwyg
XCE
XSRF
Xga
Xhzsg
Xrka
YOUw
Yarp
Yeuw
amet
bak
baz
ctor
cwj
dba
dddd
dfdc
ffff
flj
mde
mogwais
mvdtskz
pwd
sme
yyyy
Expand Down
22 changes: 5 additions & 17 deletions .github/actions/spelling/patterns.txt
Original file line number Diff line number Diff line change
@@ -1,21 +1,9 @@
[Ll][Oo][Mm][Bb][Ii][Qq]
BenedekFarkas marked this conversation as resolved.
Show resolved Hide resolved
(\((.*?)\))
BenedekFarkas marked this conversation as resolved.
Show resolved Hide resolved
(https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|www\.[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9]+\.[^\s]{2,}|www\.[a-zA-Z0-9]+\.[^\s]{2,})
BenedekFarkas marked this conversation as resolved.
Show resolved Hide resolved
[Hh]ome[Pp]age
[Dd]otnet
[Ll][Ii][Nn][Qq]
[Ll]ocalhost
[Mm][Vv][Cc]
[Uu]ncomment
[Jj]ira
[Ii][Ii][Ss]
[Cc]mdlet
[Aa]tata
[Cc][Ll][Oo][Uu][Dd][Ss][Mm][Ii][Tt][Hh]
[Ss][Dd][Kk]
[Rr][Ee][Aa][Dd][Mm][Ee]
[Oo][Ss][Oo][Cc][Ee]
[Ss][Ff][Cc]
[Cc](loud|LOUD)[Ss](mith|MITH)
[Xx][Uu]nit
[Xx][Pp][Aa][Tt][Hh]
[Rr]eadme
[Xx][Pp]ath
[{]?[0-9a-zA-Z]{8}-([0-9a-zA-Z]{4}-){3}[0-9a-zA-Z]{12}[}]?
BenedekFarkas marked this conversation as resolved.
Show resolved Hide resolved
BenedekFarkas marked this conversation as resolved.
Show resolved Hide resolved
[s][h][a][0-9]{3}-[0-9a-zA-Z\+\/]{64}
BenedekFarkas marked this conversation as resolved.
Show resolved Hide resolved
\b([a-f0-9]{40})\b
BenedekFarkas marked this conversation as resolved.
Show resolved Hide resolved
BenedekFarkas marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 2 additions & 2 deletions .github/workflows/spelling.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ on:
description: Repository with default configuration to use, the default from Check Spelling is ''
required: false
type: string
default: Lombiq/GitHub-Actions@dev
default: Lombiq/GitHub-Actions@issue/OSOE-470

jobs:
check-spelling:
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
git commit -m 'stub commit -- includes submodules'

- name: Check Spelling
uses: Lombiq/GitHub-Actions/.github/actions/spelling@dev
uses: Lombiq/GitHub-Actions/.github/actions/spelling@issue/OSOE-470
with:
dictionary-source-prefixes: ${{ inputs.dictionary-source-prefixes }}
extra-dictionaries: ${{ inputs.extra-dictionaries }}
Expand Down