Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAST-175: NuGet publishing fixes: Proper MSBuild property checks and safer SourceLink package add #232

Merged
merged 54 commits into from
Jul 25, 2023
Merged

HAST-175: NuGet publishing fixes: Proper MSBuild property checks and safer SourceLink package add #232

merged 54 commits into from
Jul 25, 2023

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented May 26, 2023 •
edited by jira bot
Loading

Piedone added 27 commits May 25, 2023 01:49
@Piedone
Merge branch 'dev' into issue/HAST-175
840faae
@Piedone
Typo
ba06d8d
@Piedone
Temporarily disabling WarnOnPackingNonPackableProject
87b676d
@Piedone
Issue branch reference for action
c648668
@Piedone
NuGet packaging now uses MSBuild to load properties even if they come…
2b476df 
… from Directory.Build.props files
@Piedone
Temporarily disabling NuGet push
1c0b5bb
@Piedone
Temporarily using GitRunners for NuGet publish
877a014
@Piedone
Maybe the Build step messes with common NuGet properties?
5d06d76
@Piedone
Another attempt to find the culprit
c9b25e4
@Piedone
Logarithmic search
359dee2
@Piedone
Re-adding everything except for "Add Source Link package"
80b2f00
@Piedone
Need to do a restore though
d0532d9
@Piedone
New script to add Microsoft.SourceLink.GitHub that doesn't overwrite …
d22e69d 
…the Directory.Build.props file
@Piedone
No need to silence warnings on non-packable projects, since the ones …
35cfcd8 
…explicitly non-packable we already ignore
@Piedone
Fixing shell config
c86c9bb
@Piedone
Trying to fix "No match was found for the specified search criteria a…
ccbf7a2 
…nd package name 'Microsoft.SourceLink.GitHub'. Try Get-PackageSource to see all available registered package sources."
@Piedone
Using explicit NuGet source
a1457e1
@Piedone
Revert "Temporarily using GitRunners for NuGet publish"
efbe3aa 
This reverts commit 877a014.
@Piedone
Readability
e7ea77a
@Piedone
Fixing path not found error
8ea22de
@Piedone
Fixing path not found error for real
212a875
@Piedone
Restore is needed now
037cbff
@Piedone
Fixing boolean expression
5e63ab2
@Piedone
Status output
3d497f2
@Piedone
Debug output
3036a48
@Piedone
Fixing MSBuild property checks during NuGet packing
815c682
@Piedone
Revert "Temporarily disabling NuGet push"
972fced 
This reverts commit 1c0b5bb.
@github-actions github-actions bot changed the title NuGet publishing fixes: Proper MSBuild property checks and safer SourceLink package add HAST-175: NuGet publishing fixes: Proper MSBuild property checks and safer SourceLink package add May 26, 2023
sarahelsaig
sarahelsaig requested changes Jun 23, 2023
View reviewed changes
.github/actions/publish-nuget/New-NuGetPackage.ps1 Outdated Show resolved Hide resolved
.github/actions/publish-nuget/New-NuGetPackage.ps1 Outdated Show resolved Hide resolved
.github/actions/publish-nuget/New-NuGetPackage.ps1 Outdated Show resolved Hide resolved
.github/actions/publish-nuget/New-NuGetPackage.ps1 Outdated Show resolved Hide resolved
.github/actions/publish-nuget/New-NuGetPackage.ps1 Outdated Show resolved Hide resolved
.github/actions/test-dotnet/Invoke-SolutionTests.ps1 Outdated Show resolved Hide resolved
.github/actions/test-dotnet/Invoke-SolutionTests.ps1 Outdated Show resolved Hide resolved
.github/actions/test-dotnet/Invoke-SolutionTests.ps1 Outdated Show resolved Hide resolved
@sarahelsaig sarahelsaig merged commit 3ec399a into dev Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahelsaig sarahelsaig sarahelsaig requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Piedone @sarahelsaig