OSOE-481: Action pulls latest SQL Server (=2022-latest) but 2019-latest is used in Lombiq.GitHub.Actions #293
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,20 @@ | ||
| if ($Env:RUNNER_OS -eq 'Windows') | ||
| { | ||
| choco install sql-server-2022 --no-progress | ||
|
|
||
| } | ||
| else | ||
| { | ||
| $sqlServerName = 'sql2022' | ||
| $sqlServerVersion = '2022-latest' | ||
|
There was a problem hiding this comment. You can use only the version eg Why don't you want to create a script parameter for this? There was a problem hiding this comment. Because we are making a load of changes to a script that was working fine and nobody wanted to touch it, until we realised that 2019 should be swapped to 2022. So according to clean code yes your recommendations are valid but the use case here is so minor and easy I think we are overcomplicating this at this point. There was a problem hiding this comment. We are making changes because there is a bug in our script and we found a maintainability problem while fixing it. Script parameter: Variable: There was a problem hiding this comment. I did change to param now. |
||
| $dockerRunSwitches = @( | ||
| '--name', $sqlServerName | ||
|
There was a problem hiding this comment. Set the container name here, value 'uitt-sqlserver'. Also see my comment below ( |
||
| '--env', 'ACCEPT_EULA=Y' | ||
| '--env', 'SA_PASSWORD=Password1!' | ||
| '--publish', '1433:1433' | ||
| '--detach', "mcr.microsoft.com/mssql/server:$sqlServerVersion" | ||
| ) | ||
|
|
||
| docker pull "mcr.microsoft.com/mssql/server:$sqlServerVersion" && | ||
| docker run @dockerRunSwitches && | ||
| docker exec --user 0 $sqlServerName bash -c 'mkdir /data; chmod 777 /data --recursive; chown mssql:root /data' | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ else | |
| { | ||
| $connectionStringStem = 'Server=.;Database=LombiqUITestingToolbox_{{id}};User Id=sa;Password=Password1!' | ||
|
|
||
| $Env:Lombiq_Tests_UI__DockerConfiguration__ContainerName = 'sql2022' | ||
|
There was a problem hiding this comment. You can set the container name here. This is the answer to your question (#293 (comment)), value |
||
| } | ||
|
|
||
| $Env:Lombiq_Tests_UI__SqlServerDatabaseConfiguration__ConnectionStringTemplate = $connectionStringStem + $connectionStringSuffix | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line 3, please do what @Piedone asked here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats what I asked for in my previous comment whether it is acceptable that we use SQL SERVER DEVELOPER instead of EXPRESS becasue I didn't find any particular command in the documentation that specifies for Express 2022.
So basically
sql-server-expressis dedicated for 2022 express and I didn't find any other command for it.sql-server-2022will install Developer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Developer would actually be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed
sql-server-expresstosql-server-2022which eventually will install the Developer versionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it makes sure that it's version 2022 and its fixed.