Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-188: YAML Linting #302

Merged
merged 64 commits into from
Jan 26, 2024
Merged

OSOE-188: YAML Linting #302

merged 64 commits into from
Jan 26, 2024

Conversation

tteguayco
Copy link
Contributor

@tteguayco tteguayco commented Dec 16, 2023

OSOE-188
Enabling linting of YAML files from:

  • GitHub Actions
  • Local development (includes instructions)

Fixes Lombiq/NodeJs-Extensions#11.

Summary by CodeRabbit

  • New Features

    • Introduced a new GitHub Action for YAML linting.
    • Added a new workflow for linting YAML files.
    • Created a spelling check action with a custom allow list.
  • Bug Fixes

    • Improved error handling in GitHub Action scripts.
  • Documentation

    • Updated documentation to include new YAML linting workflow.
    • Added guidelines for YAML linting in productivity workflows.
  • Refactor

    • Updated custom GitHub actions to reference a specific branch for consistency.
  • Chores

    • Cleaned up whitespace and minor description alterations in action configurations.
    • Updated .gitignore to include new exclusions.

This comment has been minimized.

This comment has been minimized.

@tteguayco
Copy link
Contributor Author

The configuration file is very basic right now. I assume we'll want to discuss what kind of rules we want to apply to our YAML files.

This comment has been minimized.

@DemeSzabolcs
Copy link
Member

DemeSzabolcs commented Jan 17, 2024

@Piedone, @BenedekFarkas could you please help me with merging this?

The problem is that there is a bug in Get-GHA-Items-From-File-List.ps1 (in this PR now renamed to Get-GhaItemsFromFileList.ps1), this PR includes the fix, but the bug is on dev so when I try to switch the actions to dev it will fail because of the bug, so I can't merge it.

And because of the protection rules, I can't push it to dev.

@DemeSzabolcs DemeSzabolcs added this pull request to the merge queue Jan 24, 2024
@DemeSzabolcs DemeSzabolcs removed this pull request from the merge queue due to a manual request Jan 24, 2024
@DemeSzabolcs DemeSzabolcs added this pull request to the merge queue Jan 26, 2024
Merged via the queue into dev with commit cb50f65 Jan 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint YAML files (OSOE-188)
4 participants