Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-751: Upgrade to Orchard Core 1.8 #307

Merged
merged 24 commits into from
Feb 21, 2024
Merged

OSOE-751: Upgrade to Orchard Core 1.8 #307

merged 24 commits into from
Feb 21, 2024

Conversation

Psichorex
Copy link
Contributor

@Psichorex Psichorex commented Jan 18, 2024

Copy link
Contributor

coderabbitai bot commented Jan 18, 2024

Warning

Rate Limit Exceeded

@Psichorex has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 1 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between ecb4e6a and 1db9883.

Walkthrough

The overarching modification across multiple GitHub workflow files involves updating the default .NET SDK version from 7.0.x to 8.0.x. This update reflects a move to a newer version of the .NET SDK for building, testing, and deploying applications. Additionally, some workflows have been adjusted to use specific issue branches for the setup-dotnet action, and the version of the dotnet-dump tool has been updated in a GitHub Action workflow.

Changes

Files Change Summary
.github/workflows/build-and-test-dotnet.yml
.github/workflows/build-and-test-orchard-core.yml
.github/workflows/deploy-to-azure-app-service.yml
.github/workflows/publish-nuget.yml
.github/workflows/test-analysis-failure.yml
Updated the default .NET SDK version from 7.0.x to 8.0.x.
.github/workflows/build-dotnet.yml
.github/workflows/msbuild-and-test.yml
.github/workflows/test-analysis-failure.yml
Modified the setup-dotnet action reference to use specific issue branches.
.github/actions/test-dotnet/action.yml Updated the version of the dotnet-dump tool from 7.0.421201 to 8.0.510501.

Related issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for all instances of dotnet-version.

@Psichorex
Copy link
Contributor Author

Why is the Validate GitHub Actions Refs / validate-gha-refs failing?
It says it is expecting that I use @dev but this makes no sense
Here is commit e959343
image
I addressed it in 88ad74f
After that it failed at 9defbb8
image

@Piedone
Copy link
Member

Piedone commented Feb 5, 2024

After an approve it need @dev, it's expected before a merge.

@Psichorex Psichorex added this pull request to the merge queue Feb 21, 2024
Merged via the queue into dev with commit 0a18049 Feb 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants