Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-131: Added entry in Readme and fixed error message #9

Merged
merged 3 commits into from
Jun 11, 2022
Merged

OSOE-131: Added entry in Readme and fixed error message #9

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a1590c
Add "Submodule verify workflow" section to the readme.
sarahelsaig Jun 9, 2022
d494a25
Use inputs.repo in the error message instead of hard coded "Open-Sour…
sarahelsaig Jun 9, 2022
089f718
Typo and punctuation
0liver Jun 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ jobs:
$issueCode = $Env:PULL_REQUEST_TITLE -replace '^\s*(\w+-\d+)\s*:.*$', '$1'
$lookFor = "${issueCode}:"
if (($titles | ? { $_ -and $_.Trim().StartsWith($lookFor) }).Count -gt 0) { exit 0 }
Set-Failed "Couldn't find any Open-Source-Orchard-Core-Extensions pull request whose title starts with `"$lookFor`". Please create one."
Set-Failed "Couldn't find any pull request whose title starts with `"$lookFor`" in ${{ inputs.repo }}. Please create one."
19 changes: 19 additions & 0 deletions Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,25 @@ When `source` is not provided, it assumes a default value of pushing to the [Lom

Valid values for `verbosity` are those defined by [MSBuild](https://docs.microsoft.com/en-us/visualstudio/msbuild/msbuild-command-line-reference?view=vs-2022#:~:text=you%20can%20specify%20the%20following%20verbosity%20levels). The default value is `minimal`.

### Submodule verify workflow

Verifies if the submodule contains a JIRA style issue code (e.g. PROJ-123) and if a pull request exists for the parent module. Example _publish.yml_:

```yaml
name: Verify Pull Request

on:
pull_request:

jobs:
call-verify-workflow:
uses: Lombiq/GitHub-Actions/.github/workflows/verify.yml@dev
with:
repo: Lombiq/Open-Source-Orchard-Core-Extensions
```

If this is for a submodule of [Lombiq's Open-Source Orchard Core Extensions](https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/), the `repo` input can be omitted, beucase the above is its default value. Otherwise use your parent repository's address in the `{owner}/{repo_name}` format.
0liver marked this conversation as resolved.
Show resolved Hide resolved

Refer to [Github Actions reusable workflows](https://docs.github.com/en/actions/learn-github-actions/reusing-workflows#overview) for more information.


Expand Down