OSOE-819: Add Source Generator for keeping version numbers in sync #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahelsaig
requested changes
Mar 10, 2024
...elpfulLibraries.SourceGenerators/Lombiq.HelpfulLibraries.SourceGenerators.Sample/Examples.cs
Outdated
Show resolved
Hide resolved
...elpfulLibraries.SourceGenerators/Lombiq.HelpfulLibraries.SourceGenerators.Sample/Examples.cs
Outdated
Show resolved
Hide resolved
...elpfulLibraries.SourceGenerators/Lombiq.HelpfulLibraries.SourceGenerators.Sample/Examples.cs
Outdated
Show resolved
Hide resolved
...lpfulLibraries.SourceGenerators/Lombiq.HelpfulLibraries.SourceGenerators.Sample/package.json
Outdated
Show resolved
Hide resolved
...aries.SourceGenerators/Lombiq.HelpfulLibraries.SourceGenerators/ConstantFromJsonGenerator.cs
Outdated
Show resolved
Hide resolved
...aries.SourceGenerators/Lombiq.HelpfulLibraries.SourceGenerators/ConstantFromJsonGenerator.cs
Outdated
Show resolved
Hide resolved
...ies.SourceGenerators/Lombiq.HelpfulLibraries.SourceGenerators/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
Lombiq.HelpfulLibraries.SourceGenerators/Lombiq.HelpfulLibraries.SourceGenerators/Readme.md
Outdated
Show resolved
Hide resolved
Lombiq.HelpfulLibraries.SourceGenerators/Lombiq.HelpfulLibraries.SourceGenerators/Readme.md
Outdated
Show resolved
Hide resolved
Lombiq.HelpfulLibraries.SourceGenerators/Lombiq.HelpfulLibraries.SourceGenerators/Readme.md
Show resolved
Hide resolved
|
Hey @sarahelsaig , Thank you for the feedback! I believe I have now addressed all of the changes you suggested. Please let me know if there is anything I missed or if there are additional changes needed. I have created a unit test for the generator but it's currently not actually working the way it is supposed to yet. For some reason it is not generating anything for the class I am trying to inject although it works fine in the sample class (which I have been using for manually testing so far). I might need some help with getting the unit test functional. |
sarahelsaig
reviewed
Mar 12, 2024
…es.SourceGenerators/Properties/launchSettings.json
sarahelsaig
requested changes
Mar 12, 2024
...aries.SourceGenerators/Lombiq.HelpfulLibraries.SourceGenerators/ConstantFromJsonGenerator.cs
Outdated
Show resolved
Hide resolved
...aries.SourceGenerators/Lombiq.HelpfulLibraries.SourceGenerators/ConstantFromJsonGenerator.cs
Outdated
Show resolved
Hide resolved
Lombiq.HelpfulLibraries.Tests/UnitTests/SourceGenerators/ConstantFromJsonTests.cs
Outdated
Show resolved
Hide resolved
|
@sarahelsaig Have resolved the remaining issues also |
sarahelsaig
requested changes
Mar 13, 2024
Lombiq.HelpfulLibraries.Tests/UnitTests/SourceGenerators/Utils/TestAdditionalFile.cs
Outdated
Show resolved
Hide resolved
sarahelsaig
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-819
Added a source generator to generate constants from JSON values as described in /issues/238
This allows for automatically keeping versions in sync as described in the issue above but also possible other future uses.
The newly added project can be used as a collection of any future generators.
This PR also includes a Sample project, this is not strictly needed and can be removed to prevent clutter, please let me know if that is preferred. But it is an easy way to show how to use the generator and to test.
The Readme Readme.md shows further details on how it works and how to use it.
Fixes #238