Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSIX-40: Make Dependency Injector support class declarations with 0 indentation (for file scoped namespaces) #20

Merged
merged 3 commits into from
Mar 16, 2022
Merged

VSIX-40: Make Dependency Injector support class declarations with 0 indentation (for file scoped namespaces) #20

merged 3 commits into from
Mar 16, 2022

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Mar 16, 2022

sarahelsaig
sarahelsaig requested changes Mar 16, 2022
View reviewed changes
Copy link
Member

@sarahelsaig sarahelsaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not obvious why, but it breaks when the class definition has where in it. The opening bracelet gets removed. (Works fine with other services tho.)

screen-recording.mp4

@Piedone
Copy link
Member Author

Piedone commented Mar 16, 2022

This exists in the currently released version as well (with traditional namespaces). Since this is not an urgent issue and not related to file scoped namespaces, I wouldn't venture into tackling this right now. Could you please open an issue instead?

@sarahelsaig sarahelsaig mentioned this pull request Mar 16, 2022
Open
@sarahelsaig sarahelsaig merged commit 3089db9 into dev Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahelsaig sarahelsaig sarahelsaig requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Piedone @sarahelsaig