CARE-265: Refactoring GitHub Actions workflows to DRY with common ones #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 51f3abb.
0liver
suggested changes
Nov 23, 2022
| '-property:RetryDelayMilliseconds=1000' | ||
| "-property:OutDir=$(Join-Path $PWD artifacts)" | ||
| ) | ||
| "directory=$(Join-Path $PWD artifacts)" >> $Env:GITHUB_OUTPUT |
There was a problem hiding this comment.
Why is this entry needed in $Env:GITHUB_OUTPUT?
There was a problem hiding this comment.
This is creating an output of the step, which is then used in the Build step. Since this value need so be produced in PS (or some other script), as opposed to simply using one of the GHA expressions (in which case it would be embedded in the assignment to dotnet-build-switches), we need a separate step to run this script.
There was a problem hiding this comment.
Thanks. I see now that directory is used in the following step.
0liver
approved these changes
Nov 24, 2022
0liver
approved these changes
Nov 25, 2022
0liver
approved these changes
Nov 25, 2022
|
@Piedone Please merge - I don't have write-access here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CARE-265