Skip to content

Commit

Permalink
Merge pull request #753 from Lombiq/issue/OSOE-844
Browse files Browse the repository at this point in the history
OSOE-844: Don't include a file called .htmlvalidate.json by default in Lombiq.UITestingToolbox
  • Loading branch information
Piedone authored May 6, 2024
2 parents 2b5dd08 + 78d1583 commit 4a8a030
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 18 deletions.
Original file line number Diff line number Diff line change
@@ -1,21 +1,12 @@
{
"extends": [
"html-validate:recommended"
"./default.htmlvalidate.json"
],

"rules": {
"attribute-boolean-style": "off",
"element-required-attributes": "off",
"no-trailing-whitespace": "off",
"no-inline-style": "off",
"no-implicit-button-type": "off",
"wcag/h30": "off",
"wcag/h32": "off",
"wcag/h36": "off",
"wcag/h37": "off",
"wcag/h67": "off",
"wcag/h71": "off"
"no-implicit-button-type": "off"
},

"root": true
"root": true
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using OpenQA.Selenium;
using Shouldly;
using System;
using System.IO;
using System.Linq;
using System.Threading.Tasks;
using Xunit;
Expand All @@ -27,10 +26,8 @@ public Task WalkthroughsShouldWorkCorrectly() =>
changeConfiguration: configuration =>
{
// Could be removed if https://github.com/shepherd-pro/shepherd/issues/2555 is fixed.
configuration.HtmlValidationConfiguration.HtmlValidationOptions =
configuration.HtmlValidationConfiguration.HtmlValidationOptions
.CloneWith(validationOptions => validationOptions.ConfigPath =
Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "BehaviorWalkthroughsTests.htmlvalidate.json"));
configuration.HtmlValidationConfiguration
.WithRelativeConfigPath("BehaviorWalkthroughsTests.htmlvalidate.json");
// Once the linked issues are fixed, the custom browser log assertion can be removed completely.
configuration.AssertBrowserLog = logEntries => logEntries.ShouldNotContain(
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
using Lombiq.Tests.UI.Tests.UI.TestCases;
using System.Threading.Tasks;
using Xunit;
using Xunit.Abstractions;

namespace Lombiq.OSOCE.Tests.UI.Tests.UITestingToolboxTests;

public class TimeoutTests : UITestBase
{
public TimeoutTests(ITestOutputHelper testOutputHelper)
: base(testOutputHelper)
{
}

[Fact]
public Task TestRunTimeoutShouldThrowAsync() =>
TimeoutTestCases.TestRunTimeoutShouldThrowAsync(ExecuteTestAfterSetupAsync);
}

0 comments on commit 4a8a030

Please sign in to comment.