-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSOE-751: Upgrade to Orchard Core 1.8 #673
Conversation
WalkthroughThis update primarily focuses on upgrading to Orchard Core 1.8, aligning with the latest Orchard Core improvements and API changes. It involves updates to target frameworks, package versions, and subproject commit references across various modules, utilities, and test projects. Additionally, there's a concerted effort to improve asynchronous calls and integrate new Orchard Core features, reflecting a broad enhancement of the project's functionality and compatibility with the latest Orchard Core version. Changes
Assessment against linked issues
The overall changes seem to align well with the primary objective of upgrading to Orchard Core 1.8, with some specifics about how new async features and form updates from Orchard Core PRs have been applied remaining unclear from the summary alone. Documentation updates, particularly for release notes, appear to be outside the scope of the provided changes. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
This pull request has merge conflicts. Please resolve those before requesting a review. |
NuGetTest/src/Lombiq.OSOCE.NuGet.Web/Lombiq.OSOCE.NuGet.Web.csproj
Outdated
Show resolved
Hide resolved
NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Helpers/AssertBrowserLogHelpers.cs
Outdated
Show resolved
Hide resolved
NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Tests/ModuleTests/BehaviorChartJsTests.cs
Outdated
Show resolved
Hide resolved
NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs
Outdated
Show resolved
Hide resolved
NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Tests/ModuleTests/BehaviorWalkthroughsTests.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This pull request has merge conflicts. Please resolve those before requesting a review. |
OSOE-751
Fixes #638