Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-844: Don't include a file called .htmlvalidate.json by default in Lombiq.UITestingToolbox #753

Merged
merged 27 commits into from
May 6, 2024
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
fe7917e
submodules
sarahelsaig May 1, 2024
5d4ac4d
Add TestRunTimeout config.
sarahelsaig May 2, 2024
51b70da
ExecuteOrchardCoreTestAsync
sarahelsaig May 2, 2024
504848e
Add test
sarahelsaig May 2, 2024
6daaf6b
Format code.
sarahelsaig May 2, 2024
625ff17
Update BehaviorWalkthroughsTests.htmlvalidate.json.
sarahelsaig May 2, 2024
a2388c1
Use WithRelativeConfigPath.
sarahelsaig May 2, 2024
c0372b6
Set the default config path.
sarahelsaig May 2, 2024
1cf919a
Fix typos.
sarahelsaig May 2, 2024
4400370
Code cleanup.
sarahelsaig May 2, 2024
e5e62c1
wat
sarahelsaig May 2, 2024
4cfef7d
Clone TimeoutConfiguration so it won't break when configured per-test.
sarahelsaig May 2, 2024
a1d5adf
Typo.
sarahelsaig May 2, 2024
5aa2f52
Fix error propagation.
sarahelsaig May 2, 2024
a660e1f
Fix WithRelativeConfigPath.
sarahelsaig May 2, 2024
0c27e7e
Fix spacing.
sarahelsaig May 3, 2024
d990b57
submodules
sarahelsaig May 3, 2024
6a721b2
Merge remote-tracking branch 'origin/dev' into issue/OSOE-844
sarahelsaig May 3, 2024
e765540
Fix md.
sarahelsaig May 3, 2024
cf4352e
submodules
sarahelsaig May 3, 2024
7e4462b
Remove CloneWith.
sarahelsaig May 3, 2024
cff740f
Merge remote-tracking branch 'origin/dev' into issue/OSOE-844
sarahelsaig May 3, 2024
63383b8
temporarily increase timeout to see whats the hangup
sarahelsaig May 5, 2024
867064f
revert
sarahelsaig May 5, 2024
09bc1d9
Add missing root option.
sarahelsaig May 5, 2024
6c3bec4
submodule
sarahelsaig May 5, 2024
78d1583
Updating submodules to merged dev
Piedone May 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,21 +1,12 @@
{
"extends": [
"html-validate:recommended"
"./default.htmlvalidate.json"
],

"rules": {
"attribute-boolean-style": "off",
"element-required-attributes": "off",
"no-trailing-whitespace": "off",
"no-inline-style": "off",
"no-implicit-button-type": "off",
"wcag/h30": "off",
"wcag/h32": "off",
"wcag/h36": "off",
"wcag/h37": "off",
"wcag/h67": "off",
"wcag/h71": "off"
"no-implicit-button-type": "off"
},

"root": true
"root": true
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using OpenQA.Selenium;
using Shouldly;
using System;
using System.IO;
using System.Linq;
using System.Threading.Tasks;
using Xunit;
Expand All @@ -27,10 +26,8 @@ public Task WalkthroughsShouldWorkCorrectly() =>
changeConfiguration: configuration =>
{
// Could be removed if https://github.com/shepherd-pro/shepherd/issues/2555 is fixed.
configuration.HtmlValidationConfiguration.HtmlValidationOptions =
configuration.HtmlValidationConfiguration.HtmlValidationOptions
.CloneWith(validationOptions => validationOptions.ConfigPath =
Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "BehaviorWalkthroughsTests.htmlvalidate.json"));
configuration.HtmlValidationConfiguration
.WithRelativeConfigPath("BehaviorWalkthroughsTests.htmlvalidate.json");

// Once the linked issues are fixed, the custom browser log assertion can be removed completely.
configuration.AssertBrowserLog = logEntries => logEntries.ShouldNotContain(
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
using Lombiq.Tests.UI.Tests.UI.TestCases;
using System.Threading.Tasks;
using Xunit;
using Xunit.Abstractions;

namespace Lombiq.OSOCE.Tests.UI.Tests.UITestingToolboxTests;

public class TimeoutTests : UITestBase
{
public TimeoutTests(ITestOutputHelper testOutputHelper)
: base(testOutputHelper)
{
}

[Fact]
public Task TestRunTimeoutShouldThrowAsync() =>
TimeoutTestCases.TestRunTimeoutShouldThrowAsync(ExecuteTestAfterSetupAsync);
}
Loading