Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCORE-191: Adding new Schema setup property #54

Merged
merged 6 commits into from
Jul 14, 2024
Merged

OCORE-191: Adding new Schema setup property #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f21263
Adapting IOrchardCoreApi.SetupAsync() to OC API changes
Piedone Jul 12, 2024
650bd8f
Fixing that the setup operation didn't throw if it failed
Piedone Jul 12, 2024
6cff02d
Reverting to the original implementation
Piedone Jul 13, 2024
ccce0cf
Adding missing Schema property for the setup
Piedone Jul 13, 2024
57e1da7
Removing unnecessary second recipe assignment
Piedone Jul 13, 2024
e5830dd
Merge remote-tracking branch 'origin/issue/OCC-245' into issue/OCORE-191
Piedone Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Lombiq.OrchardCoreApiClient.Tester/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ await apiClient.CreateAndSetupTenantAsync(
Name = name,
DatabaseProvider = "Sqlite",
ConnectionString = string.Empty,
RecipeName = "Blog",
UserName = "admin",
Email = "[email protected]",
Password = "Password1!",
Expand Down
3 changes: 2 additions & 1 deletion Lombiq.OrchardCoreApiClient/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ public async Task CreateAndSetupTenantAsync(

try
{
await OrchardCoreApi.SetupAsync(setupApiViewModel).ConfigureAwait(false);
using var response = await OrchardCoreApi.SetupAsync(setupApiViewModel).ConfigureAwait(false);
await response.EnsureSuccessStatusCodeAsync();
}
catch (ApiException ex)
{
Expand Down
1 change: 1 addition & 0 deletions Lombiq.OrchardCoreApiClient/Models/TenantSetupApiModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ public class TenantSetupApiModel
public string DatabaseProvider { get; set; }
public string ConnectionString { get; set; }
public string TablePrefix { get; set; }
public string Schema { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually used somewhere or only here for parity?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only for parity, if anybody needs it.


[Required]
public string UserName { get; set; }
Expand Down