Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-470: Remove false entries (actual typos) from spell checking allow lists #128

Merged
merged 4 commits into from
Dec 12, 2022
Merged

OSOE-470: Remove false entries (actual typos) from spell checking allow lists #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cee4252
Merge branch 'dev' into issue/OSOE-470
BenedekFarkas Dec 8, 2022
ac10619
Testing per-line spell-checking ignore patterns
BenedekFarkas Dec 8, 2022
3c4b6c3
Updating spell check line ignore pattern
BenedekFarkas Dec 9, 2022
a4e6100
Ignoring certain lines from spell checking
BenedekFarkas Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lombiq.DataTables/Assets/Scripts/lombiq-datatables.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
lengthChange: true,
scrollX: true,
dom: "<'row dataTables_buttons'<'col-md-12'B>>" +
"<'row dataTables_controls'<'col-md-6 dataTables_length'l><'col-md-6 dataTables_search'f>>" +
"<'row dataTables_controls'<'col-md-6 dataTables_length'l><'col-md-6 dataTables_search'f>>" + // #spell-check-ignore-line
"<'row dataTables_content'<'col-md-12't>>" +
"<'row dataTables_footer'<'col-md-12'ip>>",
buttons: useDefaultButtons,
Expand Down
2 changes: 1 addition & 1 deletion Lombiq.DataTables/ResourceManagementOptionsConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ static ResourceManagementOptionsConfiguration()
_manifest
.DefineScript(ResourceNames.DataTables.AutoInit)
.SetDependencies(ResourceNames.DataTables.Bootstrap4, ResourceNames.DataTables.Bootstrap4Buttons)
.SetUrl(Lombiq + "jquery-datatables-autoinit.js")
.SetUrl(Lombiq + "jquery-datatables-autoinit.js") // #spell-check-ignore-line
.SetVersion("1.0");

_manifest
Expand Down
3 changes: 2 additions & 1 deletion Lombiq.DataTables/Services/DataTableDataProviderBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ protected static IEnumerable<DataTableRow> SubstituteByColumn(
.ToDictionary(
cell => cell.Name,
cell => cell.Regex is { } regex
? new JValue(cell.Token?.ToString().RegexReplace(regex.From, regex.To, RegexOptions.Singleline) ?? string.Empty)
? new JValue(cell.Token?.ToString().RegexReplace(regex.From, regex.To, RegexOptions.Singleline) // #spell-check-ignore-line
?? string.Empty)
: cell.Token)));

protected async Task RenderLiquidAsync(IEnumerable<DataTableRow> rowList, IList<string> liquidColumns)
Expand Down
2 changes: 1 addition & 1 deletion Lombiq.DataTables/Tests/Lombiq.DataTables.Tests/UnitTests/Services/LiquidTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public static IEnumerable<object[]> Data()
new[]
{
("Num||^.*$||{{ '$0' | date: '%m/%d/%Y' }}", "Dates", true),
("Cls||^.*$||{{ '$0' | downcase }}", "Magic Words", true),
("Cls||^.*$||{{ '$0' | downcase }}", "Magic Words", true), // #spell-check-ignore-line
},
$"{today},foo bar baz;01/01/1970,lorem ipsum dolor sit amet;12/31/2020,the quick brown fox"
.Split(';')
Expand Down
2 changes: 1 addition & 1 deletion Lombiq.DataTables/Views/Lombiq.DataTable.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
$(function () {
var templates = {};
$(".@templatesElementName > div[data-id]").each(function(index, element) {
templates[element.getAttribute('data-id')] = element.innerHTML.replace(/%7B%7Bdata%7D%7D/g, '@templatePlaceholder');
templates[element.getAttribute('data-id')] = element.innerHTML.replace(/%7B%7Bdata%7D%7D/g, '@templatePlaceholder'); // #spell-check-ignore-line
element.parentElement.removeChild(element);
});

Expand Down