-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSOE-472: Prevent the usage of PowerShell aliases #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ticVariableAlias custom rule
… updating unit test
…s to match the style of existing analyzer rules, updating workflow to expect this analyzer
…f errors, which (it seems) is only thrown (instead of MSB3073) when there are exactly 5 analyzer violations
…s as exit code, because it trips up MSBuild
… use the beta package
… use the new beta package
sarahelsaig
requested changes
Nov 23, 2022
...nalyzers.PowerShell/Rules/Measure-AutomaticVariableAlias/Measure-AutomaticVariableAlias.psm1
Outdated
Show resolved
Hide resolved
...nalyzers.PowerShell/Rules/Measure-AutomaticVariableAlias/Measure-AutomaticVariableAlias.psm1
Outdated
Show resolved
Hide resolved
...nalyzers.PowerShell/Rules/Measure-AutomaticVariableAlias/Measure-AutomaticVariableAlias.psm1
Outdated
Show resolved
Hide resolved
...nalyzers.PowerShell/Rules/Measure-AutomaticVariableAlias/Measure-AutomaticVariableAlias.psm1
Outdated
Show resolved
Hide resolved
… and also simplifying it
…as/Measure-AutomaticVariableAlias.psm1 Co-authored-by: Dávid El-Saig <[email protected]>
Co-authored-by: Dávid El-Saig <[email protected]>
@DAud-IcI I'm closing this, because I keep having to resolve merge conflicts in OSOCE. |
…) as $PSItem is not the only automatic variable, but only one with an alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-472, fixes #12