OSOE-59: Make UI Testing Toolbox UITestManifest more generic step 1 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… maybe that'll help
# Conflicts: # Lombiq.Tests.UI/Services/TeamCityMetadataReporter.cs
# Conflicts: # Lombiq.Tests.UI/OrchardCoreUITestBase.cs
This reverts commit 3ef3f2d.
# Conflicts: # Lombiq.Tests.UI/Services/UITestContext.cs
This reverts commit dda4e18.
Piedone
commented
Feb 9, 2022
| @@ -21,6 +21,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.10.0" /> | |||
| <PackageReference Include="TeamCity.VSTest.TestAdapter" Version="1.0.34" /> | |||
There was a problem hiding this comment.
Need to add this to the wiki if it remains necessary.
…ata not being reported" This reverts commit 87ecb37.
…t a leading line break
# Conflicts: # Lombiq.Tests.UI/Lombiq.Tests.UI.csproj
This reverts commit 46af8e6.
…ront of the test name
# Conflicts: # Lombiq.Tests.UI.Samples/Lombiq.Tests.UI.Samples.csproj # Lombiq.Tests.UI.Samples/Tests/BasicTests.cs # Lombiq.Tests.UI/Extensions/AccessibilityCheckingUITestContextExtensions.cs # Lombiq.Tests.UI/Models/UITestManifest.cs # Lombiq.Tests.UI/OrchardCoreUITestBase.cs # Lombiq.Tests.UI/Services/TeamCityMetadataReporter.cs # Lombiq.Tests.UI/Services/UITestContext.cs # Lombiq.Tests.UI/Services/UITestExecutionSession.cs # Lombiq.Tests.UI/Services/UITestExecutor.cs
Piedone
commented
Apr 4, 2022
| $"##teamcity[testMetadata testName='{Escape(testName)}' name='{Escape(name)}' type='{type}' value='{Escape(value)}']"); | ||
| public static void Report(UITestManifest uiTestManifest, string name, string type, string value) => | ||
| uiTestManifest.TestOutputHelper.WriteLine( | ||
| $"##teamcity[testMetadata testName='Lombiq.Tests.UI.Samples: {Escape(uiTestManifest.Name)}' " + |
There was a problem hiding this comment.
Debug "Lombiq.Tests.UI.Samples:" prefix needs to be removed.
Piedone
commented
Apr 4, 2022
| @@ -30,7 +30,7 @@ public BasicTests(ITestOutputHelper testOutputHelper) | |||
| { | |||
| // Is the title correct? | |||
| context | |||
| .Get(By.ClassName("navbar-brand")) | |||
| .Get(By.ClassName("navbar-brandsdfds")) | |||
There was a problem hiding this comment.
Debug code needs to be removed.
Piedone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-59
Followed up under #148