Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-49: Replace Windows-only code in UI Testing Toolbox, upgrade to latest Atata/Selenium #119

Merged
merged 168 commits into from
May 26, 2022

Conversation

sarahelsaig
Copy link
Member

@sarahelsaig sarahelsaig commented Jan 22, 2022

OSOE-49

Fixes #123.

Release Notes

  • Please add these new lines to your .gitattributes, because we get IDE0055 warnings when the C# source file has Unix style line endings. Some .cs files will be affected, please run git add --renormalize . on your projects and git submodule foreach git add --renormalize . if they include submodules.
  • The setup and configuration for using SQL Server from a Docker container has changed. See new instructions here. You can also find a sample config and setup steps in the .github directory.
  • We have upgraded to Atata 2 which in turn upgraded to Selenium 4. Both introduce breaking changes, although most of it is pretty easy to fix. Replace every RemoteWebDriver with IWebDriver and if you execute scripts or take screenshots then use the extension methods (here, here and here).
  • If you have several UI test projects it can be cumbersome to maintain a TestConfiguration.json file for each. Instead, you can set the value of the LOMBIQ_UI_TESTING_TOOLBOX_SHARED_TEST_CONFIGURATION environment variable to the absolute path of a central configuration file and then each project will look it up. If you place an individual TestConfiguration.json into a test directory it will still take precedence in case you need special configuration for just that one.
  • New HelpfulLibraries.Cli project has been added, please use and expand it for all your Process and CliWrap needs.

@sarahelsaig
Copy link
Member Author

I have "resolved" the comments regarding the changes you made. I think it would've made more sense to include those as comments in your own PR.

Lombiq.Tests.UI/Extensions/StringExtensions.cs Outdated Show resolved Hide resolved
Lombiq.Tests.UI/Extensions/StringExtensions.cs Outdated Show resolved Hide resolved
Lombiq.Tests.UI/Services/AtataFactory.cs Outdated Show resolved Hide resolved
Lombiq.Tests.UI/Services/OrchardCoreInstance.cs Outdated Show resolved Hide resolved
Lombiq.Tests.UI/Services/OrchardCoreInstance.cs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to latest Selenium.Axe and Selenium.WebDriver packages (OSOE-49)
4 participants