-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSOE-49: Replace Windows-only code in UI Testing Toolbox, upgrade to latest Atata/Selenium #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ny features and shortcuts rely on that.
29 tasks
There is no point because there are separate SQL Server specific tests.
# Conflicts: # Lombiq.Tests.UI/Services/WebDriverFactory.cs
Co-authored-by: 0liver <[email protected]>
Co-authored-by: 0liver <[email protected]>
Co-authored-by: 0liver <[email protected]>
OSOE-49: Refactoring suggestion
I have "resolved" the comments regarding the changes you made. I think it would've made more sense to include those as comments in your own PR. |
0liver
suggested changes
May 25, 2022
Co-authored-by: 0liver <[email protected]>
Co-authored-by: 0liver <[email protected]>
Co-authored-by: 0liver <[email protected]>
0liver
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-49
Fixes #123.
Release Notes
git add --renormalize .
on your projects andgit submodule foreach git add --renormalize .
if they include submodules.RemoteWebDriver
withIWebDriver
and if you execute scripts or take screenshots then use the extension methods (here, here and here).LOMBIQ_UI_TESTING_TOOLBOX_SHARED_TEST_CONFIGURATION
environment variable to the absolute path of a central configuration file and then each project will look it up. If you place an individual TestConfiguration.json into a test directory it will still take precedence in case you need special configuration for just that one.Process
andCliWrap
needs.