Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-64: ConsentBanner and argument fixes. #143

Merged
merged 7 commits into from
Mar 21, 2022
3 changes: 3 additions & 0 deletions Lombiq.Tests.UI.Samples/Tests/BasicTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@ public Task ApplicationInsightsTrackingShouldBePresent(Browser browser) =>
ExecuteTestAfterSetupAsync(
async context =>
{
await context.EnableFeatureDirectlyAsync("Lombiq.Privacy.ConsentBanner");
await context.GoToHomePageAsync();

// Now there's a bit of a pickle though: The Lombiq Privacy module is also enabled from the test recipe
// and shows its privacy consent banner. For tracking to be enabled, even in offline mode, the user
// needs to give consent. This is what we do now:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Lombiq.HelpfulLibraries.Libraries.Mvc;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Mvc;
using OrchardCore.Environment.Extensions;
using OrchardCore.Environment.Extensions.Features;
Expand All @@ -10,6 +11,7 @@
namespace Lombiq.Tests.UI.Shortcuts.Controllers;

[DevelopmentAndLocalhostOnly]
[AllowAnonymous]
public class ShellFeaturesController : Controller
{
private readonly IShellFeaturesManager _shellFeatureManager;
Expand Down
2 changes: 1 addition & 1 deletion Lombiq.Tests.UI/Services/OrchardCoreInstance.cs
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public async Task<Uri> StartUpAsync()
argumentsBuilder = argumentsBuilder
.Add("--urls").Add(url)
.Add("--contentRoot").Add(_contentRootPath)
.Add("--webroot=").Add(Path.Combine(_contentRootPath, "wwwroot"))
.Add("--webroot").Add(Path.Combine(_contentRootPath, "wwwroot"))
.Add("--environment").Add("Development");

if (!useExeToExecuteApp) argumentsBuilder = argumentsBuilder.Add(_configuration.AppAssemblyPath);
Expand Down