OSOE-98: Save per-page screenshots to files directly to conserve memory #152
Conversation
This reverts commit a053514.
Lombiq.Tests.UI/Constants/Paths.cs
Outdated
| public const string DefaultSetupSnapshotDirectoryPath = "SetupSnapshot"; | ||
| public const string TempDirectoryPath = "Temp"; | ||
| public const string ScreenshotsDirectoryName = "Screenshots"; |
There was a problem hiding this comment.
Two are called *DirectoryPath one is called *DirectoryName. If this is a meaningful distinction, please comment.
By the way if you renamed the class to DirectoryPaths then you wouldn't need to prefix the variables and you could use nameof.
There was a problem hiding this comment.
How they're used there can be a difference, but let's not have that.
Lombiq.Tests.UI/Constants/Paths.cs
Outdated
| public const string TempDirectoryPath = "Temp"; | ||
| public const string ScreenshotsDirectoryName = "Screenshots"; | ||
|
|
||
| public static string GetTempSubDirectoryPath(string contextId, string subDirectoryName) => |
There was a problem hiding this comment.
I see you pass string.Empty to this below. Would it be nicer to make "" the default value of the subDirectoryName argument? Or better yet, make it params string[] subDirectoryNames?
| public static string GetTempSubDirectoryPath(string contextId, string subDirectoryName) => | ||
| Path.Combine(Environment.CurrentDirectory, Temp, contextId, subDirectoryName); | ||
| public static string GetTempSubDirectoryPath(string contextId, params string[] subDirectoryNames) => | ||
| Path.Combine(new[] { Environment.CurrentDirectory, Temp, contextId }.Union(subDirectoryNames).ToArray()); |
There was a problem hiding this comment.
.Union() is a set operator. Only use it if you want to treat your collection as a set. In this case use .Concat().
OSOE-98