Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-419: Fix that TestAdminAsMonkeyRecursivelyAsync() doesn't navigate anywhere by default #221

Merged
merged 2 commits into from
Oct 27, 2022
Merged

OSOE-419: Fix that TestAdminAsMonkeyRecursivelyAsync() doesn't navigate anywhere by default #221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eb968b
TestAdminAsMonkeyRecursivelyAsync() now navigates to the dashboard by…
Piedone Oct 26, 2022
42502c4
Adjusting comment
dministro Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Lombiq.Tests.UI/Extensions/MonkeyTestingUITestContextExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public static async Task TestFrontendAuthenticatedAsMonkeyRecursivelyAsync(
/// The username to sign in with directly. Defaults to <see cref="DefaultUser.UserName"/>.
/// </param>
/// <param name="startingRelativeUrl">
/// The relative URL to start monkey testing from. Defaults to <c>"/admin"</c>.
/// The relative URL to start monkey testing from. Defaults to <see cref="UITestContext.AdminUrlPrefix"/>.
/// </param>
public static async Task TestAdminAsMonkeyRecursivelyAsync(
this UITestContext context,
Expand All @@ -61,7 +61,9 @@ public static async Task TestAdminAsMonkeyRecursivelyAsync(
string startingRelativeUrl = null)
{
if (!string.IsNullOrEmpty(signInDirectlyWithUserName)) await context.SignInDirectlyAsync(signInDirectlyWithUserName);
if (!string.IsNullOrEmpty(startingRelativeUrl)) await context.GoToAdminRelativeUrlAsync(startingRelativeUrl);

if (string.IsNullOrEmpty(startingRelativeUrl)) await context.GoToDashboardAsync();
else await context.GoToAdminRelativeUrlAsync(startingRelativeUrl);

options ??= new MonkeyTestingOptions();
options.UrlFilters.Add(new AdminMonkeyTestingUrlFilter(context));
Expand Down