Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-751: Upgrade to Orchard Core 1.8 #338

Merged
merged 54 commits into from
Feb 21, 2024
Merged

OSOE-751: Upgrade to Orchard Core 1.8 #338

merged 54 commits into from
Feb 21, 2024

Conversation

Psichorex
Copy link
Contributor

@Psichorex Psichorex commented Jan 18, 2024

Copy link
Contributor

coderabbitai bot commented Jan 18, 2024

Walkthrough

This update primarily focuses on transitioning the Lombiq.Tests.UI project and its related components to target .NET 8.0, updating OrchardCore package references, and improving code quality and performance. Key changes include adopting new C# features such as the spread operator for array initialization, utilizing string.Create for efficient string concatenation, and refining method return types and class fields for better clarity and functionality. Additionally, it enhances logging and error handling mechanisms, aligns with OrchardCore 1.8 requirements, and updates GitHub Actions workflows for more precise branch referencing.

Changes

File Path Change Summary
Lombiq.Tests.UI/.../*.csproj Updated target framework to net8.0 and OrchardCore packages to 1.8.2.
Lombiq.Tests.UI/MonkeyTesting/MonkeyTester.cs Added System.Globalization, improved list and array initialization, optimized string operations, and refactored error handling.
Lombiq.Tests.UI/Extensions/ShortcutsUITestContextExtensions.cs Modified PurgeMediaCacheDirectlyAsync method and refactored ExecuteRecipeShortcut class. Updated IsAdminTheme method.
Lombiq.Tests.UI/Extensions/ExtendedLoggingExtensions.cs Changed ExecuteSectionAsync return type to Task<bool>.
Lombiq.Tests.UI/Services/... Updated SqlServerManager and UITestExecutionSession for better compatibility and coding practices.
.github/workflows/publish-nuget.yml Updated workflow file to use specific branch or issue reference.
Lombiq.Tests.UI/UITestBase.cs Removed unnecessary pragma directives.

Related issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

This reverts commit 5a40871.

# Conflicts:
#	Lombiq.Tests.UI/Extensions/TypedRouteUITestContextExtensions.cs
#	Lombiq.Tests.UI/Services/UITestExecutionSession.cs
This reverts commit b5bb1db.

# Conflicts:
#	Lombiq.Tests.UI/SecurityScanning/ZapManager.cs
#	Lombiq.Tests.UI/Services/AtataFactory.cs
#	Lombiq.Tests.UI/Services/UITestExecutionSession.cs
#	Lombiq.Tests.UI/Services/UITestExecutorFailureDumpConfiguration.cs
#	Lombiq.Tests.UI/Services/WebDriverFactory.cs
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PackageReference Include="Atata" Version="2.9.0" />
<PackageReference Include="Atata.Bootstrap" Version="2.1.0" />
<PackageReference Include="Atata" Version="2.14.1" />
<PackageReference Include="Atata.Bootstrap" Version="2.2.0" />
<PackageReference Include="Atata.HtmlValidation" Version="2.4.0" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentionally not upgraded because it would introduce more html-validation warnings mainly probably coming from OC source.

@Psichorex Psichorex merged commit 4980d6a into dev Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants