-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSOE-751: Upgrade to Orchard Core 1.8 #338
Conversation
WalkthroughThis update primarily focuses on transitioning the Lombiq.Tests.UI project and its related components to target .NET 8.0, updating OrchardCore package references, and improving code quality and performance. Key changes include adopting new C# features such as the spread operator for array initialization, utilizing Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Lombiq.Tests.UI/Extensions/TypedRouteUITestContextExtensions.cs
Outdated
Show resolved
Hide resolved
Lombiq.Tests.UI/Services/UITestExecutorFailureDumpConfiguration.cs
Outdated
Show resolved
Hide resolved
This reverts commit 5a40871. # Conflicts: # Lombiq.Tests.UI/Extensions/TypedRouteUITestContextExtensions.cs # Lombiq.Tests.UI/Services/UITestExecutionSession.cs
This reverts commit b5bb1db. # Conflicts: # Lombiq.Tests.UI/SecurityScanning/ZapManager.cs # Lombiq.Tests.UI/Services/AtataFactory.cs # Lombiq.Tests.UI/Services/UITestExecutionSession.cs # Lombiq.Tests.UI/Services/UITestExecutorFailureDumpConfiguration.cs # Lombiq.Tests.UI/Services/WebDriverFactory.cs
This reverts commit 4ec8de8.
Lombiq.Tests.UI/Services/OrchardCoreHosting/OrchardApplicationFactory.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #338 (comment).
# Conflicts: # Lombiq.Tests.UI/OrchardCoreUITestBase.cs
<PackageReference Include="Atata" Version="2.9.0" /> | ||
<PackageReference Include="Atata.Bootstrap" Version="2.1.0" /> | ||
<PackageReference Include="Atata" Version="2.14.1" /> | ||
<PackageReference Include="Atata.Bootstrap" Version="2.2.0" /> | ||
<PackageReference Include="Atata.HtmlValidation" Version="2.4.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentionally not upgraded because it would introduce more html-validation warnings mainly probably coming from OC source.
OSOE-751