Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-916: Change "shift time" terminology to "time shift" in Lombiq.UITestingToolbox #425

Merged
merged 8 commits into from
Nov 21, 2024
Merged

OSOE-916: Change "shift time" terminology to "time shift" in Lombiq.UITestingToolbox #425

merged 8 commits into from
Nov 21, 2024

Conversation

sarahelsaig
Copy link
Member

@sarahelsaig sarahelsaig commented Nov 20, 2024 •
edited by jira bot
Loading

OSOE-916
Fixes #422

@github-actions github-actions bot changed the title Change "shift time" terminology to "time shift" in Lombiq.UITestingToolbox OSOE-916: Change \"shift time\" terminology to \"time shift\" in Lombiq.UITestingToolbox Nov 20, 2024
@sarahelsaig sarahelsaig changed the title OSOE-916: Change \"shift time\" terminology to \"time shift\" in Lombiq.UITestingToolbox OSOE-916: Change "shift time" terminology to "time shift" in Lombiq.UITestingToolbox Nov 20, 2024
Piedone
Piedone requested changes Nov 20, 2024
View reviewed changes
Lombiq.Tests.UI.Shortcuts/Services/TimeShifterClock.cs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search for "shifttime", there are other remaining cases too.

Copy link
Member Author

@sarahelsaig sarahelsaig Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a leftover variable name in TimeShiftingClock.UpdateClock. I've updated that. The ShiftTimeTests class name should stay as-is, because it's {feature name}Tests. I did not see anything beyond those two cases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about SetShiftTimeAsync and AddShiftTimeAsync? Both of these should use "time shift" IMO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wat? I've already explained that here and you said it's okay.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you were referring to the TimeSpan change there. But otherwise still, no, that's setting the time shifting value, i.e. time shift.

Lombiq.Tests.UI.Shortcuts/Services/TimeShifterClock.cs Outdated Show resolved Hide resolved
Lombiq.Tests.UI.Shortcuts/ShortcutsFeatureIds.cs Show resolved Hide resolved
Lombiq.Tests.UI/Extensions/ShortcutsUITestContextExtensions.cs Outdated Show resolved Hide resolved
Lombiq.Tests.UI/Extensions/ShortcutsUITestContextExtensions.cs Show resolved Hide resolved
@Piedone Piedone merged commit 2d4ec85 into dev Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change "shift time" terminology to "time shift" (OSOE-916)
2 participants
@sarahelsaig @Piedone