feat: add open calendar button #457
Conversation
Abdomash
force-pushed
the
feat/settings-page-navigation
branch
from
ee479bd to
1171c5e
Compare
There was a problem hiding this comment.
LGTM but I will need @Samathingamajig opinion on one thing: This button does not check if calendar tab already exists, so it just opens a new calendar tab every time it is clicked (unlike the calendar button in the extension popup). We do not have a fix (clicking the button 2-3 times in a short period should open the calendar) but what should we do with this PR in the meantime?
|
I'm basically using the same behavior as the settings button in the main calendar tab, which opens a new settings tab each time it is clicked. A potential fix would be to replace/modify the function |
|
Please fix merge conflicts |
|
done |
| /** | ||
| * Opens the calendar page in a new tab. | ||
| * @returns A promise that resolves when the options page is opened. | ||
| */ | ||
| const handleOpenCalendar = async (): Promise<void> => { | ||
| const url = chrome.runtime.getURL('/calendar.html'); | ||
| await openTabFromContentScript(url); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Seeing as this is a useful global util, we're planning on moving it somewhere else.
This PR resolves issue #424.
Adds a button to go to the Calendar page from the Settings page without opening the extension.
Additionally, I adjusted the settings page header to match the Figma (convert from ALL CAPS to Normal Case).
Before:
After:
This change is