Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: calendar matchings #173

Merged
merged 4 commits into from
Mar 17, 2024
Merged

feat: calendar matchings #173

merged 4 commits into from
Mar 17, 2024

Conversation

Razboy20
Copy link
Member

No description provided.

@doprz doprz self-requested a review March 17, 2024 04:56
doprz
doprz requested changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very clean PR and great work! I left some minor comments that need to be addressed before merging.

src/views/components/PopupMain.tsx Outdated Show resolved Hide resolved
src/views/components/calendar/CalendarGrid/CalendarGrid.tsx Show resolved Hide resolved
src/views/components/common/ExtensionRoot/ExtensionRoot.tsx Show resolved Hide resolved
src/views/components/common/LogoIcon.tsx Outdated Show resolved Hide resolved
src/views/components/common/ScheduleListItem/ScheduleListItem.tsx Outdated Show resolved Hide resolved
src/views/components/common/ScheduleListItem/ScheduleListItem.tsx Show resolved Hide resolved
@doprz doprz merged commit 791a42b into main Mar 17, 2024
11 checks passed
@doprz doprz deleted the feat/calendar-matching branch March 17, 2024 05:32
Samathingamajig added a commit to Samathingamajig/UT-Registration-Plus that referenced this pull request Mar 17, 2024
@Samathingamajig
fix: clean up Longhorn-Developers#173
d30cb11
Razboy20 pushed a commit that referenced this pull request Mar 17, 2024
@Samathingamajig
fix: clean up #173 (#174)
afa634f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samathingamajig Samathingamajig Samathingamajig left review comments

@doprz doprz doprz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Razboy20 @Samathingamajig @doprz