Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rerouted directory to syllabus when click on professor name #211

Merged
merged 4 commits into from
May 23, 2024
Merged

feat: rerouted directory to syllabus when click on professor name #211

merged 4 commits into from
May 23, 2024

Conversation

DereC4
Copy link
Member

@DereC4 DereC4 commented May 17, 2024 •
edited by Razboy20
Loading

IsaDavRod
IsaDavRod requested changes May 19, 2024
View reviewed changes
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not include the Course Number when doing the search. Show me all the classes the instructor has taught, not just the ones from a specific course. Use First/Last name only.

@Razboy20 Razboy20 added awaiting-changes UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap labels May 19, 2024
@DereC4
Copy link
Member Author

DereC4 commented May 22, 2024

Do not include the Course Number when doing the search. Show me all the classes the instructor has taught, not just the ones from a specific course. Use First/Last name only.

sounds like a plan

@DereC4 DereC4 requested a review from IsaDavRod May 22, 2024 02:42
@IsaDavRod
Copy link
Member

Do not include the Course Number when doing the search. Show me all the classes the instructor has taught, not just the ones from a specific course. Use First/Last name only.

sounds like a plan

Also dont include department. Some instructors teach across multiple departments.

IsaDavRod
IsaDavRod requested changes May 22, 2024
View reviewed changes
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my latest comment.

@DereC4 DereC4 requested a review from IsaDavRod May 22, 2024 03:40
DereC4
DereC4 commented May 22, 2024
View reviewed changes
Copy link
Member Author

@DereC4 DereC4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@DereC4
Copy link
Member Author

DereC4 commented May 23, 2024

plzzzz

@doprz doprz self-requested a review May 23, 2024 20:01
IsaDavRod
IsaDavRod reviewed May 23, 2024
View reviewed changes
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doprz
doprz approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@doprz doprz merged commit 8959e0d into Longhorn-Developers:main May 23, 2024
6 checks passed
@DereC4
Copy link
Member Author

DereC4 commented May 24, 2024

o finally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doprz doprz doprz approved these changes

@IsaDavRod IsaDavRod IsaDavRod approved these changes

Assignees
No one assigned
Labels
ready-for-review UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DereC4 @IsaDavRod @doprz @Razboy20