Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add slight shadow on hover to calendar course cells #217

Merged
merged 2 commits into from
May 22, 2024

Conversation

Razboy20
Copy link
Member

@Razboy20 Razboy20 commented May 21, 2024

This change is Reviewable

Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this shadow consistent with the shadows we have for other buttons? (filled buttons)

@Razboy20
Copy link
Member Author

Is this shadow consistent with the shadows we have for other buttons? (filled buttons)

It's slightly lighter, but imo it looks good as-is—a more subtle shadow.

@IsaDavRod
Copy link
Member

Is this shadow consistent with the shadows we have for other buttons? (filled buttons)

It's slightly lighter, but imo it looks good as-is—a more subtle shadow.

ya I like it. I think the filled buttons shadow is supposed to be changed anyway (its a separate task on the project list)

@Razboy20 Razboy20 merged commit 40ef92b into main May 22, 2024
11 checks passed
@Razboy20 Razboy20 deleted the style/course-cell-shadow branch May 22, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants