feat: map page #390

doprz · 2024-10-23T19:58:06Z

It's finally time! I've finally ported over one of my beta features from UT Registration Planner to Plus!

Feature Summary:

Course Map to show you where to walk from class to class
Distance, walking time, and short transition time warnings
Custom select your own path
Week schedule (Rich / Text) for easy overview
Multiple schedules

This change is

Signed-off-by: doprz <[email protected]>

This reverts commit 87998ce.

Signed-off-by: doprz <[email protected]>

…stration-Plus into feature/map

Samathingamajig · 2024-10-26T16:16:13Z

src/views/components/map/CampusMap.tsx

+                                id === selected.start
+                                    ? '#579D42'
+                                    : id === selected.end
+                                      ? '#D10000'
+                                      : node.type === 'building'
+                                        ? '#BF5700'
+                                        : node.type === 'intersection'
+                                          ? '#9CADB7'
+                                          : '#D6D2C400'


can this be a function or something instead of /* eslint-disable no-nested-ternary */ at the top of the file?

Samathingamajig · 2024-10-26T16:20:20Z

src/views/components/map/CampusMap.tsx

+                            startId={path.start}
+                            endId={path.end}
+                            graph={graphNodes}
+                            color={path.colors?.primaryColor || '#BF5700'}


'#BF5700' (multiple places used in this PR) should be colors.ut.burntorange

Using our theme colors from UnoCSS don't work here so I will import them from src/shared/types/ThemeColors.ts instead.

(colors.ut.burntorange is how you'd use it when imported from src/shared/types/ThemeColors.ts, if it was a class it'd be colors-ut-burntorange :p)

Samathingamajig · 2024-10-26T16:20:30Z

src/views/components/map/CampusMap.tsx

+                                    // eslint-disable-next-line react/no-array-index-key
+                                    key={index}


Samathingamajig · 2024-10-26T16:22:54Z

src/views/components/map/DaySelector.tsx

+export const DaySelector = ({ selectedDay, onDaySelect }: DaySelectorProps) => (
+    <div className='flex gap-2 rounded-md bg-white/90 p-2 shadow-sm'>
+        {(Object.keys(DAY_MAPPING) as DayCode[]).map(day => {
+            const color = (selectedDay === day ? 'ut-burntorange' : 'ut-white') as ThemeColor;


there is no ut-white, there is ut-offwhite. I noticed this when changing as ThemeColor to satisfies ThemeColor

Good catch!

Samathingamajig · 2024-10-26T16:28:43Z

src/views/components/map/Map.tsx

+ * @param minutes The number of minutes.
+ * @returns The index value.
+ */
+const convertMinutesToIndex = (minutes: number): number => Math.floor((minutes - 420) / 30);


420 minutes corresponds with 7 a.m. being index 0, but I know of at least one 6 a.m. class

30 assumes no classes start/end on a 15-minute interval

This is the current standard that we have in the calendar so for consistency I used this.

Samathingamajig · 2024-10-26T16:32:46Z

src/views/components/map/Map.tsx

+        const timeAndLocation = `${time}${location ? ` - ${location.building} ${location.room}` : ''}`;
+
+        const midnightIndex = 1440;
+        const normalizingTimeFactor = 720;


if you go about using this constant, at least make it constant at the top, since you use it in convertMinutesToIndex

Samathingamajig · 2024-10-26T16:34:49Z

src/views/components/map/Map.tsx

+const dayToNumber = {
+    Monday: 0,
+    Tuesday: 1,
+    Wednesday: 2,
+    Thursday: 3,
+    Friday: 4,
+    Saturday: 5,
+    Sunday: 6,
+} as const satisfies Record<string, number>;


we have this exact same code in ./src/views/hooks/useFlattenedCourseSchedule.ts, extract to util?

Yes, that's a good idea. A lot of the things I have right now are for debugging without modifying external components.

Samathingamajig · 2024-10-26T16:37:15Z

src/views/components/map/Map.tsx

+                <div className='h-full flex flex-none flex-col justify-between pb-5 screenshot:hidden'>
+                    <div className='mb-3 h-full w-fit flex flex-col overflow-auto pb-2 pl-4.5 pr-4 pt-5'>
+                        <CalendarSchedules />
+                        <Divider orientation='horizontal' size='100%' className='my-5' />
+                        <ImportantLinks />
+                        <Divider orientation='horizontal' size='100%' className='my-5' />
+                        <TeamLinks />
+                    </div>
+                    <CalendarFooter />
+                </div>


feels like this part should be a shared component of some kind, not just copy/pasted

Yes, that's a good idea. A lot of the things I have right now are for debugging without modifying external components.

yeah it looks weird switching between the calendar tab and this tab because of the inconsistencies, but that'll be fixed when using external stuff

Samathingamajig · 2024-10-26T16:40:35Z

src/views/components/map/Path.tsx

+    } catch (error) {
+        console.error('Error rendering path:', error instanceof Error ? error.message : 'Unknown error');
+        return null;


what kind of errors occur/can occur?

edit: oh, PathFindingError

then is there another type of possible error?

Yes, I'm adding custom errors so that when I propagate them up I can handle them separately such as show them via a toast notification.

Samathingamajig · 2024-10-26T16:42:24Z

src/views/components/map/PathFinder.ts

@@ -0,0 +1,193 @@
+/* eslint-disable max-classes-per-file */


it makes sense to export an error class and a logic class from the same file 👍

Samathingamajig · 2024-10-26T17:30:26Z

as a user, i expected this to automatically show the lines between classes

also, I think these buttons should be pointer cursor, right now it like a text highlighter cursor

Samathingamajig · 2024-10-26T17:38:27Z

src/views/components/map/CampusMap.tsx

+                            startId={path.start}
+                            endId={path.end}
+                            graph={graphNodes}
+                            color={path.colors?.primaryColor || '#BF5700'}


(colors.ut.burntorange is how you'd use it when imported from src/shared/types/ThemeColors.ts, if it was a class it'd be colors-ut-burntorange :p)

Samathingamajig · 2024-10-26T17:43:39Z

src/views/components/map/CampusMap.tsx

+            {/* Controls and Information */}
+            <div className='absolute right-8 top-8 flex flex-col gap-4'>
+                {/* Day Selector */}
+                <DaySelector selectedDay={selectedDay} onDaySelect={handleDaySelect} />


As a user, i'd like the buttons to stay in a consistent place

Screen.Recording.2024-10-26.at.12.33.19.PM.mp4

doprz added 3 commits October 22, 2024 22:51

feat: add boilerplate

910c75a

feat: add working paths

8bf8a7f

feat: improve building selection controls and add week schedule

5500746

Signed-off-by: doprz <[email protected]>

doprz added the feature label Oct 23, 2024

doprz added this to the v2.1.0 milestone Oct 23, 2024

doprz requested a review from sghsri October 23, 2024 19:58

doprz self-assigned this Oct 23, 2024

doprz added 13 commits October 23, 2024 15:58

fix: sort week schedule

c79172d

Signed-off-by: doprz <[email protected]>

feat(testing): improve pathfinding

87998ce

Revert "feat(testing): improve pathfinding"

2a88f4f

This reverts commit 87998ce.

feat: add pathfinding with building selection controls

09ffc9b

Signed-off-by: doprz <[email protected]>

feat: improve path finding algorithm thresholds

d3a6a19

feat: add DaySelector, PathStats, and WeekSchedule components

f78870e

Merge branch 'main' of https://github.com/Longhorn-Developers/UT-Regi…

58c846b

…stration-Plus into feature/map

feat: add working stats and daily schedule

3c8c967

chore: refactor everything

8b73f1a

feat: add linear walkway node generation

0cc6329

feat: add bezier curve walkway node generation

a8abe43

feat: add circular walkway node generation

f255541

docs: add docs

7459b29

doprz marked this pull request as ready for review October 26, 2024 15:03

doprz requested review from Samathingamajig, Razboy20, IsaDavRod and DereC4 October 26, 2024 15:03

doprz modified the milestones: v2.1.0, v2.2.0 Oct 26, 2024

doprz added wip ready-for-review blocked Do not merge (yet) labels Oct 26, 2024

doprz added the UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap label Oct 26, 2024

Samathingamajig reviewed Oct 26, 2024

View reviewed changes

feat: add individual path selection and bump version

3e4207d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: map page #390

feat: map page #390

doprz commented Oct 23, 2024 •

edited

Loading

Samathingamajig Oct 26, 2024

Samathingamajig Oct 26, 2024

doprz Oct 26, 2024

Samathingamajig Oct 26, 2024

Samathingamajig Oct 26, 2024

Samathingamajig Oct 26, 2024

doprz Oct 26, 2024

Samathingamajig Oct 26, 2024

doprz Oct 26, 2024

Samathingamajig Oct 26, 2024

Samathingamajig Oct 26, 2024

doprz Oct 26, 2024

Samathingamajig Oct 26, 2024

doprz Oct 26, 2024

Samathingamajig Oct 26, 2024

Samathingamajig Oct 26, 2024

doprz Oct 26, 2024

Samathingamajig Oct 26, 2024

Samathingamajig commented Oct 26, 2024 •

edited

Loading

Samathingamajig Oct 26, 2024

Samathingamajig Oct 26, 2024

		// eslint-disable-next-line react/no-array-index-key
		key={index}

feat: map page #390

Are you sure you want to change the base?

feat: map page #390

Conversation

doprz commented Oct 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Samathingamajig commented Oct 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doprz commented Oct 23, 2024 •

edited

Loading

Samathingamajig commented Oct 26, 2024 •

edited

Loading