-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 4th attempt for: now able to delete schedule even if active #435
base: main
Are you sure you want to change the base?
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/pages/background/lib/deleteSchedule.ts
Did you find this useful? React with a 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Sam should address Instructor.ts through his PR)
src/shared/types/Instructor.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be updated in this PR. The Chromatic bug is resolved with #425
Will review with more detail soon. |
Fixes #401
First 2 images was after changes, third image is before changes
Also, SCSS seems to have an update where they no longer support @import and now use @use, which is why I changed certain .scss files or else "pnpm build" wouldn't have worked due to errors
Also also, I changed Instructor.ts because it outputs an error due to it not seeing any data and thinking there should be an error, making me fail one of the github checks, so I modified it so it doesn't output this error when there're no schedules.
This change is