feat: implement Course Statuses feature #444

ali-vayani · 2024-11-20T19:59:38Z

okay so i've been working on this PR for the past 2 days and i think i've almost got it. i'm currently having an issue with typescript being mad at me when i'm updating the usersSchedule with the updated course status

the issue is in: courseStatusChange.ts

the specific error is: where i'm getting the error: Type '{ courses: Course[]; id?: string | undefined; name?: string | undefined; hours?: number | undefined; updatedAt?: number | undefined; }' is not assignable to type 'Serialized'.
Types of property 'id' are incompatible.
Type 'string | undefined' is not assignable to type 'string'.
Type 'undefined' is not assignable to type 'string'.ts(2322)
and has to do when I'm updating the schedule.

i'm get why it's concerned about it potentially being undefined, but there is no possible way it can be undefined since the currentSchedule.map returns a course with the course type.

lmk if you have any questions, i've bunch of random things, but nothing seems to work.

also, FYI, ik the code is super messy rn, I'm just trying to get everything to work and then I'll clean it up

This change is

github-actions · 2024-11-20T19:59:56Z

Your pull request title did not conform to conventional commits standards. Our upcoming automated release pipeline will automatically determine
the proper release version based on your pull request title.
Cheat Sheet

feat: A new feature
fix: A bug fix
docs: Documentation only changes
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
refactor: A code change that neither fixes a bug nor adds a feature
perf: A code change that improves performance
test: Adding missing tests or correcting existing tests
build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
chore: Other changes that don't modify src or test files
revert: Reverts a previous commit

github-actions · 2024-11-20T20:00:02Z

Your pull request title did not conform to conventional commits standards. Our upcoming automated release pipeline will automatically determine
the proper release version based on your pull request title.
Cheat Sheet

feat: A new feature
fix: A bug fix
docs: Documentation only changes
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
refactor: A code change that neither fixes a bug nor adds a feature
perf: A code change that improves performance
test: Adding missing tests or correcting existing tests
build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
chore: Other changes that don't modify src or test files
revert: Reverts a previous commit

doprz · 2024-11-20T20:03:54Z

src/assets/insideJokes.tsx

@@ -115,6 +115,7 @@ const splashText: string[] = [
    `It's ${new Date().toLocaleString('en-US', { month: 'long', day: 'numeric' })} and OU still sucks`,
    'As seen on TV!	',
    "Should you major in Compsci? well, here's a better question. do you wanna have a bad time?",
+    "https://i.redd.it/4y3fc2bzva1e1.gif",


This is not related to this PR in addition that we shouldn't include random links. Please remove.

doprz · 2024-11-20T20:04:10Z

src/pages/background/handler/courseStatusChange.ts

+import { resolve } from "path";
+
+
+export default async function checkCourseStatusChanges() {


Needs jsdoc.

doprz · 2024-11-20T20:04:22Z

src/pages/background/handler/courseStatusChange.ts

@@ -0,0 +1,67 @@
+import { UserScheduleStore } from "src/shared/storage/UserScheduleStore";


Use path alias.

doprz · 2024-11-20T20:06:13Z

src/pages/background/handler/courseStatusChange.ts

+                        const scrapedStatus = scraper.getStatus(row)[0];
+                        newStatus = scrapedStatus as StatusType;


Ideally we should have some validation here.

doprz · 2024-11-20T20:06:51Z

src/pages/background/handler/courseStatusChange.ts

+                        const scrapedStatus = scraper.getStatus(row)[0];
+                        newStatus = scrapedStatus as StatusType;
+                    }
+                    console.log('Unique ID:', uniqueId);


This should have some further context if needed for logging. Otherwise this is just verbose and should be removed.

doprz · 2024-11-20T20:11:48Z

src/views/components/calendar/CalenderHeader.tsx

 import SettingsIcon from '~icons/material-symbols/settings';
+import checkCourseStatusChanges from 'src/pages/background/handler/courseStatusChange';


Use path alias.

doprz · 2024-11-20T20:12:09Z

src/views/components/settings/Settings.tsx

+    useEffect(() => {
+        console.log(enableCourseStatusChips, "settings");
+    },[enableCourseStatusChips])


debug console.log. Should be removed later on.

doprz · 2024-11-20T20:12:15Z

src/views/components/settings/Settings.tsx

@@ -138,7 +141,7 @@ export default function Settings(): JSX.Element {
        // Listen for changes in the settings
        const l1 = OptionsStore.listen('enableCourseStatusChips', async ({ newValue }) => {
            setEnableCourseStatusChips(newValue);
-            // console.log('enableCourseStatusChips', newValue);
+            console.log('enableCourseStatusChips', newValue);


debug console.log. Should be removed later on.

doprz · 2024-11-20T20:12:30Z

src/views/lib/CourseCatalogScraper.ts

@@ -211,7 +211,7 @@ export class CourseCatalogScraper {
     */
    getInstructionMode(row: HTMLTableRowElement): InstructionMode {
        const text = (row.querySelector(TableDataSelector.INSTRUCTION_MODE)?.textContent || '').toLowerCase();
-
+        


Random indentation.

doprz · 2024-11-20T20:12:59Z

src/views/components/calendar/CalenderHeader.tsx

-                        {/* <button className='inline-block h-4 w-4 bg-transparent p-0 btn'>
+                        <button 
+                            className='inline-block h-4 w-4 bg-transparent p-0 btn'
+                            onClick={async () => await checkCourseStatusChanges()}


nit. I would extract this into a dedicated function.

how is this any different from onClick={checkCourseStatusChanges}?

doprz · 2024-11-20T20:14:00Z

Also please make sure that all checks are passing.

feat: ts error

4c1d99d

doprz changed the title ~~(DRAFT) feat: implement Course Statuses feature~~ feat: implement Course Statuses feature Nov 20, 2024

doprz marked this pull request as draft November 20, 2024 20:00

doprz marked this pull request as ready for review November 20, 2024 20:01

ali-vayani marked this pull request as draft November 20, 2024 20:01

doprz marked this pull request as ready for review November 20, 2024 20:02

doprz assigned ali-vayani Nov 20, 2024

doprz added awaiting-changes blocked Do not merge (yet) feature wip labels Nov 20, 2024

doprz marked this pull request as draft November 20, 2024 20:02

doprz added this to the v2.1.0 milestone Nov 20, 2024

doprz requested changes Nov 20, 2024

View reviewed changes

Merge branch 'main' into 360

3d66459

DereC4 linked an issue Nov 22, 2024 that may be closed by this pull request

[FEATURE] Implement Course Statuses #360

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement Course Statuses feature #444

feat: implement Course Statuses feature #444

ali-vayani commented Nov 20, 2024 •

edited by Razboy20

Loading

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

doprz Nov 20, 2024

doprz Nov 20, 2024

doprz Nov 20, 2024

doprz Nov 20, 2024

doprz Nov 20, 2024

doprz Nov 20, 2024

doprz Nov 20, 2024

doprz Nov 20, 2024

doprz Nov 20, 2024

doprz Nov 20, 2024

Samathingamajig Nov 22, 2024

doprz commented Nov 20, 2024

		import { resolve } from "path";


		export default async function checkCourseStatusChanges() {

		@@ -0,0 +1,67 @@
		import { UserScheduleStore } from "src/shared/storage/UserScheduleStore";

		const scrapedStatus = scraper.getStatus(row)[0];
		newStatus = scrapedStatus as StatusType;

		import SettingsIcon from '~icons/material-symbols/settings';
		import checkCourseStatusChanges from 'src/pages/background/handler/courseStatusChange';

feat: implement Course Statuses feature #444

Are you sure you want to change the base?

feat: implement Course Statuses feature #444

Conversation

ali-vayani commented Nov 20, 2024 • edited by Razboy20 Loading

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doprz commented Nov 20, 2024

ali-vayani commented Nov 20, 2024 •

edited by Razboy20

Loading