feat(ui): update theme colors #466 #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
IsaDavRod
requested changes
Dec 31, 2024
There was a problem hiding this comment.
Lets do the following changes:
- Rename
offwhitetooff-whiteand all instances - Remove
concretesince it's not a UT color. I think theres like one instance of it being used. For any instances, please change them tout-gray - Rename
lightgreentolight-greenand all instances (also very few or none exist)
|
It appears that UnoCSS doesn't support kebab-cased colors. The hyphen is reserved for color prefixes e.g. "ut-..." |
IsaDavRod
requested changes
Jan 2, 2025
doprz
added
ready-for-review
UI/UX-figma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated colors within the ThemeColors.ts file.
The issue requested that the colors
off-white-1andoff-white-2be added. It's worth mentioning that there is already a theme calledoffwhite, so we may want to change theseoffwhite-1andoffwhite-2to keep naming consistent.We could also change the name to
off-whiteinstead, but this would require us to replace the CSS variable across the project.This change is