Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fetch efficiency in insert_curation #1072

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix fetch efficiency in insert_curation #1072

merged 2 commits into from
Aug 20, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Aug 16, 2024

Description

Quickfix for 1070. Not a breaking bug but made unnecessary fetch of full v0.Curation tables (currently has ~10^5 entries). instead only fetch and return key of interest.

Checklist:

  • NO This PR should be accompanied by a release: (yes/no/unsure)
  • NA If release, I have updated the CITATION.cff
  • NO This PR makes edits to table definitions: (yes/no)
  • NA If table edits, I have included an alter snippet for release notes.
  • NA If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • NA I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 marked this pull request as ready for review August 16, 2024 18:55
@CBroz1 CBroz1 linked an issue Aug 20, 2024 that may be closed by this pull request
@CBroz1 CBroz1 merged commit 36a8bda into master Aug 20, 2024
7 checks passed
@CBroz1 CBroz1 deleted the 1070_fix branch August 20, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Curation v0 fetching incorrectly
2 participants