Skip to content

Commit

Permalink
Added self.unique_identifier to the battery class
Browse files Browse the repository at this point in the history
Used to identify a BMS when multiple BMS are connected
planned for future use
  • Loading branch information
mr-manuel committed Apr 28, 2023
1 parent eaa6e3b commit 89cfe0a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

* Added: Balancing status for JKBMS by @mr-manuel
* Added: Balancing switch status for JKBMS by @mr-manuel
* Added: Balancing switch status to the GUI -> SerialBattery -> IO by @mr-manuel
* Added: Balancing switch status to the GUI -> SerialBattery -> IO
* Added: `self.unique_identifier` to the battery class. Used to identify a BMS when multiple BMS are connected - planned for future use by @mr-manuel
* Added: Charge Mode display by @mr-manuel
* Added: Choose how battery temperature is assembled (mean temp 1 & 2, only temp 1 or only temp 2) by @mr-manuel
* Added: Config file by @ppuetsch
Expand Down
3 changes: 3 additions & 0 deletions etc/dbus-serialbattery/battery.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ def __init__(self, port, baud, address):
self.max_battery_charge_current = None
self.max_battery_discharge_current = None

# used to identify a BMS when multiple BMS are connected - planned for future use
self.unique_identifier = None

@abstractmethod
def test_connection(self) -> bool:
"""
Expand Down
2 changes: 1 addition & 1 deletion etc/dbus-serialbattery/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def _get_list_from_config(

# Constants - Need to dynamically get them in future
DRIVER_VERSION = "1.0"
DRIVER_SUBVERSION = ".0 (20230427)"
DRIVER_SUBVERSION = ".0 (20230428)"
zero_char = chr(48)
degree_sign = "\N{DEGREE SIGN}"

Expand Down

0 comments on commit 89cfe0a

Please sign in to comment.