Daly_Can - on v1.1.20240112dev starts working (nearly) #919
Labels
bug
Something isn't working
Comments
mr-manuel
added a commit
to mr-manuel/venus-os_dbus-serialbattery
that referenced
this issue
Jan 12, 2024
|
Can you please install the nightly from my branch and test if it works? In your case this should work with: bash /data/etc/dbus-serialbattery/install.shThen select |
|
Can you please enable it again. I startet the install from an wrong pi.
Now on the right one it is gone ;-(
Greetings, Holger
… Am 12.01.2024 um 14:28 schrieb Manuel ***@***.***>:
Can you please install the nightly from my branch and test if it works?
In your case this should work with:
bash /data/etc/dbus-serialbattery/install.sh
Then select nightly build (option 3) -> dev (mr-manuel's repo) (option 3).
—
Reply to this email directly, view it on GitHub <#919 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2HE4NHHCPFQLTOURYN4RDYOE3BVAVCNFSM6AAAAABBYBOK6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGIYDQNZRGQ>.
You are receiving this because you authored the thread.
|
|
Hello Manuel greetings, Holger Last login: Fri Jan 12 17:30:27 2024
root@raspberrypi2:~# tail -F -n 100 /data/log/dbus-canbattery.can8/current | tai64nlocal
2024-01-12 17:30:32.389509500 INFO:SerialBattery:> LINEAR LIMITATION ENABLE: True
2024-01-12 17:30:32.389519500 INFO:SerialBattery:> MAX BATTERY CHARGE CURRENT: 10.0A | MAX BATTERY DISCHARGE CURRENT: 40.0A
2024-01-12 17:30:32.389524500 INFO:SerialBattery:> CVCM: True
2024-01-12 17:30:32.389527500 INFO:SerialBattery:> MIN CELL VOLTAGE: 2.9V | MAX CELL VOLTAGE: 3.45V
2024-01-12 17:30:32.389532500 INFO:SerialBattery:> CCCM CV: True | DCCM CV: True
2024-01-12 17:30:32.389537500 INFO:SerialBattery:> CCCM T: True | DCCM T: True
2024-01-12 17:30:32.389660500 INFO:SerialBattery:> CCCM SOC: True | DCCM SOC: True
2024-01-12 17:30:32.389664500 INFO:SerialBattery:Serial Number/Unique Identifier: DalyBMS4cells_NoneAh
2024-01-12 17:30:34.440181500 INFO:SerialBattery:Found existing battery with DeviceInstance = 2
2024-01-12 17:30:34.684706500 INFO:SerialBattery:DeviceInstance = 2
2024-01-12 17:30:34.685286500 INFO:SerialBattery:Used device instances: ['1', '3', '12', '4', '9', '5', '10', '6', '7', '2', '14', '13', '8', '11']
2024-01-12 17:30:34.685822500 INFO:SerialBattery:com.victronenergy.battery.can8
2024-01-12 17:30:34.706321500 INFO:SerialBattery:publish config values = True |
|
Sorry, this is the logfile AFTER rebooting: Also, do i need to populate all the parameters into my config.ini ? 2024-01-12 18:30:04.549606500 *** CCGX booted (0) ***
2024-01-12 18:31:56.995809500
2024-01-12 18:31:58.967776500 INFO:SerialBattery:
2024-01-12 18:31:58.968400500 INFO:SerialBattery:Starting dbus-serialbattery
2024-01-12 18:31:58.969630500 INFO:SerialBattery:dbus-serialbattery v1.1.20240112dev
2024-01-12 18:32:00.056268500 INFO:SerialBattery:-- Testing BMS: 1 of 3 rounds
2024-01-12 18:32:00.056845500 INFO:SerialBattery:Testing Daly_Can
2024-01-12 18:32:00.187786500 INFO:SerialBattery:DalyBMS 4 cells
2024-01-12 18:32:00.188749500 INFO:SerialBattery:Connection established to Daly_Can
2024-01-12 18:32:00.189269500 INFO:SerialBattery:Battery Daly_Can connected to dbus from can8
2024-01-12 18:32:00.189715500 INFO:SerialBattery:========== Settings ==========
2024-01-12 18:32:00.190172500 INFO:SerialBattery:> Connection voltage: NoneV | Current: NoneA | SoC: None%
2024-01-12 18:32:00.190615500 INFO:SerialBattery:> Cell count: 4 | Cells populated: 0
2024-01-12 18:32:00.191085500 INFO:SerialBattery:> LINEAR LIMITATION ENABLE: True
2024-01-12 18:32:00.191641500 INFO:SerialBattery:> MAX BATTERY CHARGE CURRENT: 10.0A | MAX BATTERY DISCHARGE CURRENT: 40.0A
2024-01-12 18:32:00.192087500 INFO:SerialBattery:> CVCM: True
2024-01-12 18:32:00.192559500 INFO:SerialBattery:> MIN CELL VOLTAGE: 2.9V | MAX CELL VOLTAGE: 3.45V
2024-01-12 18:32:00.193004500 INFO:SerialBattery:> CCCM CV: True | DCCM CV: True
2024-01-12 18:32:00.193457500 INFO:SerialBattery:> CCCM T: True | DCCM T: True
2024-01-12 18:32:00.193891500 INFO:SerialBattery:> CCCM SOC: True | DCCM SOC: True
2024-01-12 18:32:00.194419500 INFO:SerialBattery:Serial Number/Unique Identifier: DalyBMS4cells_NoneAh
2024-01-12 18:32:02.322136500 INFO:SerialBattery:Found existing battery with DeviceInstance = 2
2024-01-12 18:32:02.558154500 INFO:SerialBattery:DeviceInstance = 2
2024-01-12 18:32:02.558759500 INFO:SerialBattery:Used device instances: ['1', '3', '12', '4', '9', '5', '10', '6', '7', '2', '14', '13', '8', '11']
2024-01-12 18:32:02.559327500 INFO:SerialBattery:com.victronenergy.battery.can8
2024-01-12 18:32:02.579348500 INFO:SerialBattery:publish config values = True |
What should I enable again? To have proper code formatting add trippe backticks or tildes
No, only relevant for your system. All other are fetched from the So all is working and I can close this issue? |
|
Hello Manuel I will try the ~~~ thx for this Tip. The Readings from CAN are working now, but i an not shure if it is all correct, i don´t see the Cell Voltages in the Venus - only the min and max Voltage. But that will be another Issue - this one is ready to be closed. HoW |
Louisvdw
pushed a commit
that referenced
this issue
Feb 28, 2024
* fix Sinowealth not loading #702 * fix unique identifier function * enable BMS over config, if disabled by default Now you can also add more then one BMS for BMS_TYPE * show battery port in log * ANT BMS fixes Fixed that other devices are recognized as ANT BMS * Sinowealth BMS fixes Fixed that other devices are recognized as Sinowealth BMS * improved publish_battery error handling switched from error count to seconds * Improve Battery Voltage Handling in Linear Absorption Mode * Refactor change time() to int(time()) for consistency in max_voltage_start_time and tDiff calculation * Refactor battery voltage calculations for efficiency and clarity * Remove penalty_buffer * Reset max_voltage_start_time wenn we going to bulk(dynamic) mode * updated changelog * fix reply processing * Reduce the big inrush current, if the CVL jumps from Bulk/Absorbtion to Float fix #659 * Check returned data lenght for Seplos BMS Be stricter about the return data we accept, might fix the problem of grid meters accidently being recognized as a Seplos * Validate current, voltage, capacity and SoC for all BMS This prevents that a device, which is no BMS, is detected as BMS * removed double check * bump version * fix validation if None * updated changelog * proposal to #659 formatted :) * bugfix proposal to #659 * refactor setting float charge_mode * fix type error, removed bluetooth cronjob * updated changelog * fix rs485 write communication errors by inserting sleeps, add debug print for charge mode and fix crash on write soc failures * fix write problem on set_soc. also changed the switch charge/discharge function, just in case * debug msg * Bluetooth optimizations * Fixes by @peterohman #505 (comment) * fix #712 * fix meaningless time to go values * fix meaningless time to go values * Duration of transition to float depends on number of cells * Float transition - Voltage drop per second * Update hlpdatabms4s.py * Validate setting of FLOAT_CELL_VOLTAGE and avoid misconfiguration * consider utils.LINEAR_RECALCULATION_EVERY to refresh CVL * cleanup * consider utils.LINEAR_RECALCULATION_EVERY to refresh CVL * small refactor, introduced set_cvl_linear function to set CVL only once every LINEAR_RECALCULATION_EVERY seconds * fix typo * updated changelog * remove debug msg * remove debug msg * undo debug change * Daly BMS make auto reset soc configurable * added debug and error information for CVL * fix proposal for #733 (#735) * Added: Tollerance to enter float voltage once the timer is triggered * Add bulk voltage Load to bulk voltage every x days to reset the SoC to 100% for some BMS * JKBMS disable high voltage warning on bulk reenable after bulk was completed * fixed error * disable high voltage warning for all BMS when charging to bulk voltage * fix error and change default value measurementToleranceVariation from 0.025 to 0.5 else in OffGrid mode max voltage is always kept * Added temperature names to dbus/mqtt * Use current avg of last 300 cycles for TTG & TTS * Calculate only positive Time-to-SoC points * added current average of last 5 minutes * make CCL and DCL more clear * fix small error * bugfix: LLTJBD BMS SOC different in Xiaoxiang app and dbus-serialbattery * black formatting * JDB BMS - Control FETs for charge, discharge and disable / enable balancer (#761) * feature: Allow to control charge / discharge FET * feature: Allow to enable / disable balancer * bugfix: Cycle Capacity is in 10 mAh Fixes SoC with factor 100 * 100% percentage * JBD BMS show balancer state in GUI page IO (#763) * Bump version * Fix typos * Smaller fixes - fixes #792 (comment) * Removed comments from utils.py This should make more clear that there are no values to change * Updated changelog * possible fix for LLT/JBS connection problems #769 #777 * bugfix: LLT/JBD BMS general packet data size check * improved reinstall and disable script * LLT/JBD BMS - Improved error handling and automatical driver restart in case of error. Should fix: - #730 - #769 - #777 * Fixed Building wheel for dbus-fast won't finish on weak systems Fixes #785 * Support for Daly CAN Bus (#169) * support for Daly CAN Bus * fix constructor args * revert port, needs fix * add can filters * comment logger Some changes are still needed to work with the latest version. They will follow in a next PR. --------- Co-authored-by: Samuel Brucksch <[email protected]> Co-authored-by: Manuel <[email protected]> * JKBMS BLE - Introduction of automatic SOC reset (HW Version 11) (#736) * Introduction of automatic SOC reset for JK BMS (HW Version 11) * Fixed value mapping * Rework of the code to make it simpler to use without additional configuration. Moved execution of SOC reset. It's now executed while changing from "Float" to "Float Transition". * Implementation of suggested changes Persist initial BMS OVP and OVPR settings Make use of max_cell_voltage to calculate trigger value for OVP alert * Added: Daly CAN and JKBMS CAN * added CAN bms to installation script optimized CAN drivers * smaller fixes * Trigger JK BLE SOC reset when using Step Mode * Moved trigger_soc_reset() * fixes LLT/JBD SOC > 100% #769 * changed VOLTAGE_DROP behaviour * Fix JKBMS not starting if BMS manuf. date is empty * corrected bulk, absorption and soc reset terms * fix typo * add JKBMS_BLE debugging data * fix small error * Some changes for lost bluetooth connection / hci_uart stack restart * added logging to config * add sleep before starting driver prevents lot of timeouts after reinstalling the driver, since the restart is now much faster than before * changed post install info * fix error * Daly BMS fixed embedded null byte #837 * added info for SoC reset to default config file * fix for #716 #716 * fix for #716 and JKBMS model recognition #716 * optimized logging * fix JKBMS recognition * added debugging * fixes #716 #716 * Bind device instance to unique_identifier #718 * added data types to battery class disabled unused variables * save current charge state #840 * correct file permissions * updated changelog * added periodic saveChargeDetails * fix some small errors * fix issue with ruuvi tags When there are hundreds of unused ruuvi tags in the settings list that where added because thei where nearby the driver does not start correctly. These stale entries are disabled on the driver startup. The issue was already filed to Victron developers * CVL with i-controller instead of penaltysum * cvl_controller: switch to choose PenaltySum or ICOntroller + documentation * docu enhancement * Add setting and install logic for usb bluetooth module * round temperatures * changed battery disconnect behaviour * Fixes #891 #891 * updated changelog * Add bluetooth device note to config.default.ini * Fix typo in bluetooth note in config.default.ini * fixed error in new cvl_controller * fixed float division by zero and code optimization * Restart MAX_VOLTAGE_TIME_SEC if cell diff > CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_TIME_RESTART * Calculation of the SOC based on coloumb-counting (#868) * Calculation of the SOC in the driver based on coloumb-counting * soc_calc: add current correction before integration * soc_calc: correction map for current * Soc_calc: CorrectionMap, switch to turn on/off correction, selectable initial value * soc_calc: Bugfix * soc_calc: Bugfix * store soc in dbus for restart * store soc in dbus for restart (formatted) * store soc in dbus for restart (bugfix) * save soc_calc only after change > 1.0 * store soc in dbus for restart (bugfix) * logger does not work this way. do not know why * writing and reading to dbus works * Removed options: SOC_CALC_CURRENT_CORRECTION, SOC_CALC_RESET_VALUE_ON_RESTART, SOC_CALC_INIT_VALUE sort soc_calc alphabetically * fixed comments * Updated changelog, small fixes * Changed: PUBLISH_CONFIG_VALUES from 0/1 to True/False * Changed: Code optimizations - Changed some variables to be more clear - Added comments for easier code understanding * Calculated SOC: Added two decimals, added BMS SOC for MQTT & Node-RED * Updated changelog, small fixes * Changed: PUBLISH_CONFIG_VALUES from 0/1 to True/False * Changed: Code optimizations - Changed some variables to be more clear - Added comments for easier code understanding * Calculated SOC: Added two decimals, added BMS SOC for MQTT & Node-RED * Fix #898 #898 * Changed: Fix issue loading settings from dbus * Added nightly install option makes it easier for users to pretest fixes * Changed: more detailed error output when an exception happens * Possible fix for #912 #912 * Fixes #919 #919 * Changed: Exit script with error, if port excluded else the serialstarter stops at the dbus-serialbattery * Fixed some smaller errors * Updated pre-release workflow * Fix JK BMS connection restart when bluetooth fails. This fix installs a new thread to monitor the state of the original scraping thread. If scraping thread dies, it verifies that it did not because the scraping was intentionally stopped by calling stop_scrapping. When restarting the scrapper, it first calls the bluetooth reset lambda function that was passed in the class contructor, such that bluetooth is ready to make a proper connection. * Fixes #916 #916 * Added Venus OS version to logfile * Fix #840 #840 * Small code formatting fixes * Optimized reinstall script. Restart GUI only on changes. * Display debugging data in GUI when DEBUG enabled * Install script now shows repositories and version numbers * Update daly_can.py Fixing #950 for DalyBMS * Update jkbms_can.py Fixing #950 for Jk BMS * Fix black lint check * Fixes #970 #970 * Fixed some errors in restoring values from dbus settings * Moved sleep on start for all BMS * Update config description * Reworked a part of the default config * fix typo in stopping services when reinstalling * Fix Time-to-SoC and Time-to-Go calculation * Add changelog info * Round sum and diff voltage * Temperature limitation variables where changed * SoC limitation variables where changed * Added error messages * Remove unneeded code * Reset SoC to 0% if empty * Add GUIv2 for dbus-serialbattery * Check free space before installing * Added new GUIv2 version * Removed Python 2 compatibility * Changelog update * Code cleanup - Removed: get_temperatures() - Removed: update_last_seen() * Bluetooth code optimizations * Fixed some JKBMS BLE not starting #819 * Check if packages are already installed before install * Fixed some SOC calculation errors * Fixed None SOC on driver start * Do not show and allow button change when callback is missing for: - ForceChargingOff - ForceDischargingOff - TurnBalancingOff * Check if a device instance is already used by creating a PID file * Log and execute SOC reset to 100% or 0% only once * Update GitHub workflow and issue templates * Fixed LLT/JBD BMS with only on temperature sensor #791 #971 * Fix warning on reinstall * Fix missing IO control for JBDBMS #992 #992 * Prepare for removing dev branch --------- Co-authored-by: ogurevich <[email protected]> Co-authored-by: Bernd Stahlbock <[email protected]> Co-authored-by: wollew <[email protected]> Co-authored-by: Oleg Gurevich <[email protected]> Co-authored-by: peterohman <[email protected]> Co-authored-by: Strawder, Paul <[email protected]> Co-authored-by: Paul Strawder <[email protected]> Co-authored-by: Samuel Brucksch <[email protected]> Co-authored-by: Samuel Brucksch <[email protected]> Co-authored-by: ArendsM <[email protected]> Co-authored-by: Meik Arends <[email protected]> Co-authored-by: Marvo2011 <[email protected]> Co-authored-by: cflenker <[email protected]> Co-authored-by: cflenker <[email protected]> Co-authored-by: Cupertino Miranda <[email protected]> Co-authored-by: Martin Polehla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
At first see my logfile:
After updating this seems to give an endless loop, see the Errror messages in the first half.
How to reproduce
If you want me to tryout more with the Daly on CAN-Bus feel free to contact me, the settings is now working in my Lab.
Keep on with your fantastic Work, best Whishes from Austria. Holger Watermann
Expected behavior
.After commenting out the IF inside battery.py it starts to work without further complains.
# if BMS limit is lower then config limit and therefore the values are not the same, # then the limit was also read from the BMS # if utils.MAX_BATTERY_CHARGE_CURRENT > self.max_battery_charge_current: # charge_limits.update({self.max_battery_charge_current: "BMS Settings"})Driver version
v1.1.20240112dev
Venus OS device type
Raspberry Pi 2
Venus OS version
v3.20~37
BMS type
Daly Smart BMS
Cell count
4
Battery count
1
Connection type
Raspberry Pi RS485 HAT
Config file
Relevant log output
Any other information that may be helpful
There is no CAN Profile selector here to chooose from, so please add it. I took RS485 HAT.
I use an normal CAN HAT on the pi and that gives me can8 connected to the included CAN L/H Lines of the DALY bms.
Addditional Findings:
As it seems, the DALY_CAN has an enabled 120 Ohms Terminator connectet, so connect only one more at he other end of your CAN Bus! This gives you the normal 60 Ohm on the Bus (measure without power attached)
The text was updated successfully, but these errors were encountered: