-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sinowealth based Daly BMS support #41
Conversation
…hipset used in the daly BMS)
@Louisvdw thanks for the review, valid points! I will make the changes and try to test them before posting again. |
@Carstijn
|
@Louisvdw I made some changes, to fix your comments, pleas re-review. About the list, creating and deleting it does not feel very optimal, do you have something about my latest solution? (creating once in settings and only updating) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work adding the Sinowealth Daly
This implements support for Sinowealth chipset based BMS, for now limited to SH367303 / 367305 / 367306 / 39F003 / 39F004 / BMS_10 chips with up to 10 cells. I have tested this with my Daly SmartBMS 4S 250A BMS, this is based on the SH39F003 chipset. My battery bank is a lishen 4s3p, 12 cell 840 Ah 12V bank installed on my boat. Using a solar MPPT and Multiplus 12/3000 for charging and Venus GX device + BMV712 for controlling the setup.
What works:
What kinda works
Reading cycles is implemented, but does not match bluetooth app value
What is not implemented
The BMS has more data avaiable in the app, I am not able to read this data atm. It seems there is some way to read "extended parameter" pages, no clue on how to do this. Because of this some values are hard coded, like cell voltage thresholds and discharge and charge current limits.
On this pull request