Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeToGo #424

Merged
merged 3 commits into from
Jan 20, 2023
Merged

TimeToGo #424

merged 3 commits into from
Jan 20, 2023

Conversation

corneel27
Copy link
Contributor

@corneel27 corneel27 commented Jan 16, 2023

Second PR (with corrections off typo's)now publishing to "TimeToGo"

added LowSoc in dbus TimeToGo items
First PR published to wrong path.
I cancelled it.
Now TimeToGo is published to /TimeToGo/
corrected typo's
@corneel27
Copy link
Contributor Author

Only the last commit is the right one.Don't know how to delete the other commits

@Louisvdw Louisvdw merged commit 6471152 into Louisvdw:master Jan 20, 2023
@Louisvdw
Copy link
Owner

fix #406

@mr-manuel
Copy link
Collaborator

Hi @corneel27,

do you have a screenshot how it looks in your Venus OS? I tried a few options and on my end it works only when I set TIME_TO_SOC_VALUE_TYPE = 1.

grafik

With all other options I get:

grafik

dbus-spy

# TIME_TO_SOC_VALUE_TYPE = 1 --> working in Venus OS GUI
TimeToGo                                    90513
TimeToSoC/0                                115311
TimeToSoC/10                               102912
TimeToSoC/100                                   -
TimeToSoC/15                                96712
TimeToSoC/30                                78114
TimeToSoC/5                                109111
TimeToSoC/60                                40916
TimeToSoC/90                                 3719
TimeToSoC/95                                    -

# TIME_TO_SOC_VALUE_TYPE = 2 --> NOT working in Venus OS GUI
TimeToGo                           1 day, 6:51:36
TimeToSoC/0                       1 day, 15:18:53
TimeToSoC/10                      1 day, 11:05:14
TimeToSoC/100                                   -
TimeToSoC/15                       1 day, 8:58:25
TimeToSoC/30                       1 day, 2:37:57
TimeToSoC/5                       1 day, 13:12:04
TimeToSoC/60                             13:57:01
TimeToSoC/90                              1:16:05
TimeToSoC/95                                    -

# TIME_TO_SOC_VALUE_TYPE = 3 --> NOT working in Venus OS GUI
TimeToGo                         73421 [20:23:41]
TimeToSoC/0                93537 [1 day, 1:58:57]
TimeToSoC/10                     83479 [23:11:19]
TimeToSoC/100                                   -
TimeToSoC/15                     78450 [21:47:30]
TimeToSoC/30                     63364 [17:36:04]
TimeToSoC/5                88508 [1 day, 0:35:08]
TimeToSoC/60                      33190 [9:13:10]
TimeToSoC/90                       3017 [0:50:17]
TimeToSoC/95                                    -

For what were the TimeToSo* values planned, if they are not displayed anywhere? For fetching over MQTT or did you intend to add it to the GUI?

@corneel27
Copy link
Contributor Author

I only fixed the generation of correct "Time to go".
I have nothing to do with publishing the correct values in the remote console or the vrm app/site.
I think Louis can answer your question.
I have installed the latest stable version on my Venus device, so I can't tell you anything of my experience with the develop version.

@mr-manuel
Copy link
Collaborator

For what were the TimeToSo* values planned, if they are not displayed anywhere? For fetching over MQTT or did you intend to add it to the GUI?

@CaptKrisp or @Louisvdw maybe one of you can answer me that?

@CaptKrisp
Copy link
Contributor

The TimeToSoC/* values are provided for programmatic convenience. Most commonly used in NodeRed dashboards for display or flows for determining when to switch external loads/systems on/off, etc.
The use of these values in the VenusOS GUI doesn't seem practical since people generally are concerned only how much time remains before battery reaches a lower level of depletion or until fully charged.

@mr-manuel
Copy link
Collaborator

Thank you!

@mr-manuel mr-manuel mentioned this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants