jkbms_ble: 32s-Support and connection workaround for bt-fail #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
baranator
commented
Feb 16, 2023
baranator
commented
- Support for newer jkbms that send frames with up to 32 cell infos.
- Also a workaround for the bug that causes the bluetooth-connection to fail after 15 hours and 22 mins
…st is executed, further work required
…o that the bt-connection can be tested
… if no bt-device is available during test_connection
mr-manuel
reviewed
Feb 20, 2023
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| # zero means parse all incoming data (every second) | |||
| CELL_INFO_REFRESH_S = 0 | |||
| DEVICE_INFO_REFRESH_S = 60 * 60 * 5 # every 5 Hours | |||
| DEVICE_INFO_REFRESH_S = 60 * 60 * 10 # every 10 Hours | |||
There was a problem hiding this comment.
Is there a reason why you chose 10 hours and not 12 hours?
There was a problem hiding this comment.
tbh: That line can be removed completely as it not used anymore - device-info only contains non-changing data that do not need to be updated after connect.
That change comes from back then, when we tried to figure out where that crashes come from...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.