Many improvements #620
Merged
Many improvements #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added missing descriptions - changed name
should be None instead of 0, if not available
- Added: Show TimeToSoc only, if enabled - Changed: description in config file - Changed: default value TIME_TO_SOC_VALUE_TYPE = 1
- changed: how often Time-To-Soc is calculated in seconds
- changed: Time-To-Go has to be always a positive int since it's used from dbus-systemcalc-py - changed: how Time-to-SoC is string is generated and displayed (format like Time-To-Go)
Pull request from @baphomett Louisvdw/dbus-serialbattery#440
respecting semantic versioning
- `/data/conf/serial-starter.d` was not recreated if deleted
- added description in utils.py - change qml files in destination not source
* on disconnect, show '---' after 10s and 'not connected' after 60s by @transistorgit * small fixes in shell script * added restart driver script
before float voltage was applied
* Choose to block charge/discharge on disconnect * Trigger Venus OS alarm
* show self.unique_identifier as serial number * show self.production as device name
this adds the battery production date
|
Hey @mr-manuel can this already be used? I have 4 jkbms with 4x 16s. So i can give it a try and give feedback |
|
Yes it's already working |
* Set SoC on button press by @transistorgit * Improved driver stability by @transistorgit & @mr-manuel
mr-manuel
changed the title
Louisvdw
approved these changes
May 8, 2023
Louisvdw
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.inito the root of a USB flash drive on install via the USB method by @mr-manuelReleaseandPre-release.Release: v0.0.0Pre-release: v0.0.0s, v0.0.0string, v0.0.0-s or v0.0.0-string. After the string can anything be attached.