Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renogy #79

Merged
merged 3 commits into from
Jan 9, 2022
Merged

Renogy #79

merged 3 commits into from
Jan 9, 2022

Conversation

Louisvdw
Copy link
Owner

@Louisvdw Louisvdw commented Jan 9, 2022

No description provided.

gambleben and others added 3 commits December 8, 2021 13:47
* Renogy baseline

First attempt to get Renogy Smart Lithium battery working with this driver.
* Fixed serial number parsing
* Fix python 2.7 errors.
* Manually set cell count
* Fix cell voltages, added cell temps, total capacity, bms temp 1 and 2, cleaned up some code.
* Minor tweak to address to use ASCII 0
@Louisvdw Louisvdw merged commit a1a954f into master Jan 9, 2022
@Louisvdw Louisvdw linked an issue Jan 9, 2022 that may be closed by this pull request
6 tasks
@Louisvdw Louisvdw deleted the renogy branch January 18, 2022 15:25
@Louisvdw
Copy link
Owner Author

Hi @gambleben
If possible can you test https://github.com/Louisvdw/dbus-serialbattery/releases/tag/v0.12b4 to see if that still works with your version of the Renogy.

@gambleben
Copy link
Contributor

gambleben commented Sep 21, 2022 via email

@gambleben
Copy link
Contributor

Are you including minimalmodbus with the project now? That would honestly make implementation of the full Renogy spec much easier.

@Louisvdw
Copy link
Owner Author

After v0.11 the driver needed some changes to be able to work with the structure changes in VenusOS 2.80+ and also for python3. These are not backward compatable anymore which ment we can assume everything will be in Python3 and thus I could include Minimalmodbus.
So you can assume it will be available, and use it.

@Louisvdw
Copy link
Owner Author

I have been playing with the multiple battery (VenusOS cal them Multi Banks) feature a bit.

Here is how I see the multi battery working.
The serialbattery will create it's own custom path in the dbus.
Each battery/BMS will read it's data and "store" that under this custom dbus path.
There has to be a master service that will be doing the publish to the dbus. It will combine all the data from the custom dbus path for each bms and then publish this to the victron paths.

There are also a few new batteries that I am working on that also need similar changes and it could also help with easier setup up for users. What happens with the SBMS is that the battery is not polled for data, but it just publish it so you need to be listening. And so it needs some master service as well.

The master service could also be what is installed by default. And then the user can do a battery detection so that the driver does not need to run though all the possible battery types each time. They can then also setup that battery with the settings needed which will move all the settings out from utils.py, but this needs a GUI

There is also a ticket open to add bluetooth support for the driver. One of the reasons I have started with that is the set up that is needed to be detected (addresses) and I think the driver needs a UI that can handle that. Seeing as you have done a bit of the bluetooth already maybe we can start with that using any hard codes for now and then move to a GUI and other BMS step by step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renogy BMS Integration
2 participants