Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes 2023.09.19 #810

Merged
merged 2 commits into from
Sep 19, 2023
+6 −4
Merged

Changes 2023.09.19 #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7be087f
smaller fixes
mr-manuel Sep 19, 2023
81c20ff
Merge branch 'Louisvdw:dev' into dev
mr-manuel Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions etc/dbus-serialbattery/bms/mnb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@

# # MNB is disabled by default
# can be enabled by specifying it in the BMS_TYPE setting in the "config.ini"
# https://github.com/Louisvdw/dbus-serialbattery/commit/65241cbff36feb861ff43dbbcfb2b495f14a01ce
# remove duplicate MNB lines
# https://github.com/Louisvdw/dbus-serialbattery/commit/23afec33c2fd87fd4d4c53516f0a25f290643c82
# https://github.com/Louisvdw/dbus-serialbattery/issues/590
# https://community.victronenergy.com/comments/231924/view.html

from battery import Protection, Battery, Cell
from utils import logger
Expand Down
3 changes: 3 additions & 0 deletions etc/dbus-serialbattery/dbus-serialbattery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@


def main():
# NameError: free variable 'expected_bms_types' referenced before assignment in enclosing scope
global expected_bms_types

def poll_battery(loop):
helper.publish_battery(loop)
return True
Expand Down
2 changes: 1 addition & 1 deletion etc/dbus-serialbattery/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def _get_list_from_config(


# Constants
DRIVER_VERSION = "1.0.20230917dev"
DRIVER_VERSION = "1.0.20230919dev"
zero_char = chr(48)
degree_sign = "\N{DEGREE SIGN}"

Expand Down