Adding S3 Compatible Storage Support and Changing "timeout" to "frequency" #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding s3 endpoint
Modifying timeout to frequency
Removing binary
|
In general I probably won't want to rename properties based on a particular individuals desires because it would lead to a lot of churn for any existing users of the application - but in this particular case, I think renaming timeout to frequency (or interval or something like that) makes sense. I'll see if I can get this merged in today. |
|
@nehrman Are you able to run the Go formatter on your PR? It looks like the |
Lucretius
reviewed
Sep 21, 2020
| @@ -13,7 +13,7 @@ import ( | |||
| type Configuration struct { | |||
| Address string `json:"addr"` | |||
| Retain int64 `json:"retain"` | |||
| Timeout string `json:"freq"` | |||
| Frequency string `json:"frequency"` | |||
There was a problem hiding this comment.
Looks like the formatter needs to be run here
|
Thank you for the PR. I've gone and merged it, and built a new release (v0.1.0) for you to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
So I recreated a PR without the binary and with the last changes I made about timeout.
My customer asked to change this as this was not very clear to him and he prefers to have "frequency" instead.