Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code dealing with state reception #202

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Simplify code dealing with state reception #202

merged 1 commit into from
Dec 3, 2024

Conversation

fleborne
Copy link
Contributor

  • state is a dict, so we can check if state is not empty with if state:
  • self._state seems unused in PyLuos and the '_' prefix seems to discourage users from using it in their apps. So I propose to delete this attribute.

nicolas-rabault
nicolas-rabault approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better indeed. Thank you

@nicolas-rabault nicolas-rabault merged commit 9001272 into Luos-io:rc_3.1.0 Dec 3, 2024
@fleborne fleborne deleted the feat/improve-state-reception branch December 12, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-rabault nicolas-rabault nicolas-rabault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fleborne @nicolas-rabault