New feature: push despite empty state #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because the Gate behavior has been modified we always have to push despite an empty state or we could have a locking situation (the same one you are in right now). |
|
Alright, I remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new state was pushed (from PyLuos objects to Gate) only if the Gate had sent back a network state.
I propose to add a parameter to allow bypassing this, by pushing the changes made on PyLuos objects even when no new state has been received from the Gate. The parameter added is
push_despite_empty_statein pyluos.device.Device constructor.The default behavior is left unchanged.