Fixes upload fails for non-existent partner video upload to S3 #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilure Previously, the S3 upload flow attempted to upload a partner video regardless of its existence, resulting in an error when the video was missing. This error prevented the job responsible for uploading the original variant to S3 from completing successfully. This commit adds a check to ensure the partner video exists before attempting to upload, resolving the issue and allowing the job to complete as expected.
|
I have no idea what the test error means. |
|
Hi @kiancross thanks for the PR. I'll try to investigate hat is going wrong. |
ildyria
approved these changes
Dec 27, 2024
|
Tests pass on my machine... |
ildyria
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the S3 upload flow attempted to upload a partner video regardless of its existence, resulting in an error when the video was missing. This error prevented the job responsible for uploading the original variant to S3 from completing successfully.
This commit adds a check to ensure the partner video exists before attempting to upload, resolving the issue and allowing the job to complete as expected.
Fixes one of the bugs described here: #2521.