Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Module/Side-effects): replace redux-observable with redux-cycles #178

Merged
merged 8 commits into from
Mar 6, 2017

Conversation

evenchange4
Copy link
Member

@evenchange4 evenchange4 commented Mar 5, 2017

cyclejs
for #179

@evenchange4
Copy link
Member Author

evenchange4 commented Mar 5, 2017

Deploy preview ready!

Built with commit 0bcc16d

https://deploy-preview-178--mcs-lite-ui.netlify.com

@evenchange4
Copy link
Member Author

evenchange4 commented Mar 5, 2017

Deploy preview ready!

Built with commit 0bcc16d

https://deploy-preview-178--mcs-lite-mobile-web.netlify.com

@michaelhsu-bot
Copy link
Collaborator

michaelhsu-bot commented Mar 5, 2017

Warnings
⚠️ ❗ Big PR

Generated by 🚫 dangerJS

@evenchange4
Copy link
Member Author

evenchange4 commented Mar 5, 2017

Codecov Report

Merging #178 into master will increase coverage by 1.68%.
The diff coverage is 97.27%.

@@            Coverage Diff            @@
##           master    #178      +/-   ##
=========================================
+ Coverage   84.72%   86.4%   +1.68%     
=========================================
  Files         118     119       +1     
  Lines         825     883      +58     
=========================================
+ Hits          699     763      +64     
+ Misses        126     120       -6
Impacted Files Coverage Δ
...cs-lite-mobile-web/src/containers/Signin/Signin.js 100% <ø> (ø)
...ackages/mcs-lite-mobile-web/src/modules/routing.js 100% <100%> (ø)
packages/mcs-lite-mobile-web/src/utils/helpers.js 100% <100%> (ø)
packages/mcs-lite-mobile-web/src/modules/ui.js 100% <100%> (ø)
packages/mcs-lite-mobile-web/src/modules/index.js 100% <100%> (ø)
...es/mcs-lite-mobile-web/src/store/configureStore.js 100% <100%> (ø)
...ackages/mcs-lite-mobile-web/src/modules/devices.js 100% <100%> (+12.5%)
packages/mcs-lite-mobile-web/src/modules/auth.js 95.08% <92.3%> (+2.58%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b658f93...0bcc16d. Read the comment docs.

@evenchange4 evenchange4 changed the title refactor(Module) replace redux-observable with redux-cycles refactor(Module/Side-effects): replace redux-observable with redux-cycles Mar 5, 2017
@evenchange4 evenchange4 merged commit 00f14e5 into master Mar 6, 2017
@evenchange4 evenchange4 deleted the refactor/redux-cycle branch March 6, 2017 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants